Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the default headers with request_kwargs passed to (Async)HTTPProvider #3551

Open
souliane opened this issue Dec 6, 2024 · 0 comments

Comments

@souliane
Copy link

souliane commented Dec 6, 2024

What feature should we add?

Hi,

This is nice: 86827d6
because it allows to build the header without having an instantiated object, and then pass them to the constructor.
(edit: I am actually wondering: why decorate get_request_headers with @combomethod and not @classmethod?!)

But it would be IMHO more straightforward if what is passed in request_kwargs["headers"] was used to extend the result of HTTPProvider.get_request_headers.

I am willing to open a PR, if you agree with this idea.

@souliane souliane changed the title Extend the default headers with request_kwargs passed to (Async)HTTPProvider Update the default headers with request_kwargs passed to (Async)HTTPProvider Dec 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@souliane and others