You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is nice: 86827d6
because it allows to build the header without having an instantiated object, and then pass them to the constructor.
(edit: I am actually wondering: why decorate get_request_headers with @combomethod and not @classmethod?!)
But it would be IMHO more straightforward if what is passed in request_kwargs["headers"] was used to extend the result of HTTPProvider.get_request_headers.
I am willing to open a PR, if you agree with this idea.
The text was updated successfully, but these errors were encountered:
souliane
changed the title
Extend the default headers with request_kwargs passed to (Async)HTTPProvider
Update the default headers with request_kwargs passed to (Async)HTTPProvider
Dec 7, 2024
What feature should we add?
Hi,
This is nice: 86827d6
because it allows to build the header without having an instantiated object, and then pass them to the constructor.
(edit: I am actually wondering: why decorate
get_request_headers
with@combomethod
and not@classmethod
?!)But it would be IMHO more straightforward if what is passed in
request_kwargs["headers"]
was used to extend the result ofHTTPProvider.get_request_headers
.I am willing to open a PR, if you agree with this idea.
The text was updated successfully, but these errors were encountered: