Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in the seasonal bias plots #33

Open
jesusff opened this issue Jan 14, 2025 · 2 comments
Open

Some fixes in the seasonal bias plots #33

jesusff opened this issue Jan 14, 2025 · 2 comments
Assignees

Comments

@jesusff
Copy link
Contributor

jesusff commented Jan 14, 2025

This is introducing a 0.35K bias, right? the offset for degC to K should be 273.15
https://github.com/euro-cordex/joint-evaluation/blob/58b71dd6b61cd066686ce69731cb0b9165eb9304/eval-book/eobs.ipynb#L1253C29-L1253C34

We should use the source_id as labels, rather than the institution_id (the same institution can run different models)
https://github.com/euro-cordex/joint-evaluation/blob/58b71dd6b61cd066686ce69731cb0b9165eb9304/eval-book/eobs.ipynb#L1259

@larsbuntemeyer
Copy link
Contributor

Agreed! I'll update as soon as possible. Do you have an opinion on #9 ?

@jesusff
Copy link
Contributor Author

jesusff commented Jan 14, 2025

yes, I'd go for the missings threshold to get rid of those awful artifacts in the biases

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants