-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Template sheet #8
Comments
Yes. You mean the excel file or the readme file? |
The excel sheet. But I think it might be better we drive it, and get back to you when needed, to clarify some issues, or to validate it |
So I tried to update the template of walking complete. I placed in orange and column some comments. Might be worth discussing it a bit. @alfonsotecnalia could you check the PI Algo spec? Regarding each PI, if we address the first one, the other will follow I guess:
I am wondering whether we could place the labels inside the PI file, as suggested in this issue. Any opinion? On the intra-run, I think no aggregation is feasible: we cannot compress it more. |
I have already check the spec and include some comments.
I would say it would be good to include the label tag as the different parts of the vector have different meaning |
Resuming the action Intra run aggregation: how to compress a PI score more
inter run aggregation: we have several captures: how to combine the pi of the different runs
|
I updated the entries for the input files and the program command as well. @alfonsotecnalia I left in the current format, @simonePasi, please focus on the aggregation part, I think this is the last thing we would need to complete the metric part. |
@aremazeilles I prefer to leave "standard deviation" entry in the PIs. Is it a problem? For single runs the value could be NaN |
could you identify the entry you are referring to? |
Intra run aggregation:
inter run aggregation: same as intra run aggregation |
I think we still have to make some iteration here. Let start with the first ones:
So my suggestion would be: intra_run_aggregation: na (Not applicable, ie the result stays as is)
inter_run_aggregation: [mean] @alfonsotecnalia how do you write mean of the first entry of all vectors?? I would also suggest extending the PI format with: type: 'vector'
label: ['mean', ' std', ' step number' ]
value: [170.73955, 27.67778, 12.00000] |
I'm agree with your suggestion: inter_run_aggregation: mean and rms values i.e.
|
That would thus be: # peak_load_{left, right}
inter_run_aggregation: [[-,0], mean] #i.e mean of all 1st entry of vector, mean of the mean
# rms_load_{left, right}
inter_run_aggregation: [[0], rms] # rms of all values
# stance_time_{left, right}
inter_run_aggregation: [[-,0], mean] #i.e mean of all 1st entry of vector, mean of the mean For the peak_load_shoulder and rms_load_shoulder, you expect to get a 6 entry vector, where each entry is the mean /rms value of all related vector entry, is that correct? |
Correct. |
ping @alfonsotecnalia @simonePasi
Resuming activity. From what I see the code is in good shape. We would just have to update the template sheet with the appropriate info on the PI part, correct?
The text was updated successfully, but these errors were encountered: