Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with libs using style-loader #16

Open
ostrolucky opened this issue Apr 16, 2018 · 0 comments
Open

Doesn't work with libs using style-loader #16

ostrolucky opened this issue Apr 16, 2018 · 0 comments

Comments

@ostrolucky
Copy link
Contributor

style-loader is webpack loader which allows libraries to import css into their js library. The way it works is it dynamically creates <style> element first time js library is used. This is used by eg ckeditor 5.

Now, here's a problem. Ajaxcom removes <style> elements each time there is new page load and injects the ones it got via backend. This dynamic <style> is of course not in there, so won't be re-added. Additionally, style-loader doesn't check for presence of this <style> in following runs.

What happens from user POV is that everything is ok when such library is used for a first time, but when ajaxcom loads page again, this <style> is missing now and html added by this library is unstyled.

ref: ckeditor/ckeditor5#960

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant