Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress max socket warning for invalid bases #68

Open
c20k20w opened this issue Sep 19, 2020 · 2 comments
Open

Suppress max socket warning for invalid bases #68

c20k20w opened this issue Sep 19, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@c20k20w
Copy link

c20k20w commented Sep 19, 2020

Max socket warning which was introduced in #63 does not care about the type of the item - as a result, you get specious warnings about helmets having a max of 4 sockets when that's the expected number, one handed weapons (and thin 2h weapons) having max of 5 etc for lower itemlevel gear. A filter for the typeLine should suppress all warnings above its natural max sockets.

@pboutin
Copy link
Member

pboutin commented Sep 19, 2020

Oh that's right, I just checked with body armors, didn't think of the smaller bases. I also noticed the warning shows up for Tabula, probably will hide it this weekend and fix it later.

@pboutin pboutin added the bug Something isn't working label Sep 19, 2020
@pboutin
Copy link
Member

pboutin commented Sep 20, 2020

Will include a better fix for it later on, but for now, i will only scope the feature for body armors.

#69

Thanks again for the hint @c20k20w

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants