From 204a107fe975cdbb0a758727c8b531d33528ae4f Mon Sep 17 00:00:00 2001
From: expani <anijainc@amazon.com>
Date: Tue, 28 Jan 2025 15:44:36 -0800
Subject: [PATCH] Added short circuit to matching

Signed-off-by: expani <anijainc@amazon.com>
---
 .../search/aggregations/startree/ArrayBasedCollector.java    | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java b/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java
index 57ba8374a610a..6aad0fbaafd2c 100644
--- a/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java
+++ b/server/src/test/java/org/opensearch/search/aggregations/startree/ArrayBasedCollector.java
@@ -29,11 +29,10 @@ public void collectStarTreeNode(StarTreeNode node) {
     }
 
     public boolean matchAllCollectedValues(long... values) throws IOException {
-        boolean matches = true;
         for (long value : values) {
-            matches &= nodeDimensionValues.contains(value);
+            if (!nodeDimensionValues.contains(value)) return false;
         }
-        return matches;
+        return true;
     }
 
     public int collectedNodeCount() {