-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Graph rendering seems broken in master #5
Comments
oops? |
I ran this on Kotlin 1.3.70, due to the Experimental nature of the feature maybe not only binary compatibility broke but also "semantical" compatibility (for lack of a better word)? |
after looking at it again i have not using the code from this repository for a while because jitpack is just not that stable.. so i copied the sources into my own projact and must have fixed that.. or copied things before the PR... i would also suggest to roll that partially back then |
And what about the usage of the experimental feature? |
is there any time library we could use that is multiplatform compatible ? not sure if @eyeem is still using or maintaining this library either.. |
First of all thanks for this neat little project!
Unfortunately, this PR seems to have broken timeline rendering. I have attached two screenshots from
Test 1 - Linear Sleep
where you can see the regression.Before PR (6bfc65f):
Current master:
In addition to that, the change to experimental MonoClock also means this library will break for projects using Kotlin 1.3.70 because of binary incompatible changes in MonoClock (allowed due to experimental).
I do think it is a good idea to use a monotonic clock for time measurements, but using an experimental interface in a library does not seem like a good idea to me, so switching from
System.currentTimeMillis()
toSystem.nanoTime()
might be a more stable option.So my proposal would be to revert that PR. If you are eager to keep the monotonic clock I can prepare a PR to use
System.nanoTime
.The text was updated successfully, but these errors were encountered: