Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: EZA_GRID_ROWS does not have any effect on grid details view #1044

Closed
LeoniePhiline opened this issue Jul 1, 2024 · 3 comments
Closed

bug: EZA_GRID_ROWS does not have any effect on grid details view #1044

LeoniePhiline opened this issue Jul 1, 2024 · 3 comments
Labels
errors Something isn't working

Comments

@LeoniePhiline
Copy link
Contributor

LeoniePhiline commented Jul 1, 2024 •
edited
Loading

This is a follow-up to #66 (comment) and the discussion following it.

On eza, main branch, EZA_GRID_ROWS does not effectively prevent a grid view from being rendered if the threshold of configured number of rows is not reached.

The intention of EZA_GRID_ROWS is to force a details list view if there are only few items in the result set.

A fix is implemented in #1043.
@LeoniePhiline LeoniePhiline added the errors Something isn't working label Jul 1, 2024
@cafkafk
Copy link
Member

cafkafk commented Jul 1, 2024

However, from a functionality perspective, as an end user I would expect this to apply to plain EZA_GRID_ROWS=1234 eza as well, without involvement of details views.

To be perfectly honest I'm extremely sick from covid so I can't really be of much help rn, but I vague get the sense that the current intention behind EZA_GRID_ROWS (whether it works or not) could be done differently, and maybe should be...

@cafkafk
Copy link
Member

cafkafk commented Jul 1, 2024

fwiw from the man page:

   EZA_GRID_ROWS
       Limits the grid-details view (`eza --grid --long') so it’s only  activated  when
       at least the given number of rows of output would be generated.

       With  widescreen  displays,  it’s  possible  for  the grid to look very wide and
       sparse, on just one or two lines with none of the columns lining up.  By  speci‐
       fying  a  minimum  number of rows, you can only use the view if it’s going to be
       worth using.

@LeoniePhiline
Copy link
Contributor Author

To be perfectly honest I'm extremely sick from covid

I wish you the best! Get well soon! ❤️‍🩹

@LeoniePhiline LeoniePhiline mentioned this issue Jul 1, 2024
Merged
cafkafk pushed a commit to LeoniePhiline/eza that referenced this issue Aug 7, 2024
@LeoniePhiline @cafkafk
fix: implement EZA_GRID_ROWS grid details view minimum rows threshold
6e4c817 
Grid details view had been prevented only by console width being
unavailable.

This changeset implements `EZA_GRID_ROWS` as secondary grid details
inhibitor, preventing grid details view if the minimum rows threshold is
not reached by grid which would be rendered.

Fix:
eza-community#66 (comment)
Fix: eza-community#1044

BREAKING CHANGE: Before this change, the `EZA_GRID_ROWS` variable was
ignored, despite documentation existing. Users relying on `EZA_GRID_ROW`
not doing anything will find their output changed. For more info, see
cafkafk pushed a commit to LeoniePhiline/eza that referenced this issue Aug 7, 2024
@LeoniePhiline @cafkafk
fix!: implement EZA_GRID_ROWS grid details view minimum rows threshold
a204e4a 
Grid details view had been prevented only by console width being
unavailable.

This changeset implements `EZA_GRID_ROWS` as secondary grid details
inhibitor, preventing grid details view if the minimum rows threshold is
not reached by grid which would be rendered.

Fix:
eza-community#66 (comment)
Fix: eza-community#1044

BREAKING CHANGE: Before this change, the `EZA_GRID_ROWS` variable was
ignored, despite documentation existing. Users relying on `EZA_GRID_ROW`
not doing anything will find their output changed. For more info, see
@cafkafk cafkafk closed this as completed in 97a8abe Aug 7, 2024
erwinvaneijk pushed a commit to erwinvaneijk/eza that referenced this issue Oct 1, 2024
@LeoniePhiline @erwinvaneijk
fix!: implement EZA_GRID_ROWS grid details view minimum rows threshold
ae4cd12 
Grid details view had been prevented only by console width being
unavailable.

This changeset implements `EZA_GRID_ROWS` as secondary grid details
inhibitor, preventing grid details view if the minimum rows threshold is
not reached by grid which would be rendered.

Fix:
eza-community#66 (comment)
Fix: eza-community#1044

BREAKING CHANGE: Before this change, the `EZA_GRID_ROWS` variable was
ignored, despite documentation existing. Users relying on `EZA_GRID_ROW`
not doing anything will find their output changed. For more info, see
tertsdiepraam pushed a commit to tertsdiepraam/eza that referenced this issue Oct 10, 2024
@LeoniePhiline @tertsdiepraam
fix!: implement EZA_GRID_ROWS grid details view minimum rows threshold
096f0a4 
Grid details view had been prevented only by console width being
unavailable.

This changeset implements `EZA_GRID_ROWS` as secondary grid details
inhibitor, preventing grid details view if the minimum rows threshold is
not reached by grid which would be rendered.

Fix:
eza-community#66 (comment)
Fix: eza-community#1044

BREAKING CHANGE: Before this change, the `EZA_GRID_ROWS` variable was
ignored, despite documentation existing. Users relying on `EZA_GRID_ROW`
not doing anything will find their output changed. For more info, see
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
errors Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@LeoniePhiline @cafkafk