[Feature]: Change PencilBrush private fields to protected #10411
DinosaurDad
started this conversation in
Ideas
Replies: 1 comment
-
Please open a PR and do it. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
CheckList
Description
Obviously the FabricJS 6.x codebase is now based on classes, which is great because subclassing is now easier/cleaner than with FabricJS 5.x and earlier.
I have a subclass of PencilBrush to add a few things, and override a couple of methods that work with the
private
fields like_points[]
. As there are no get/set accessors, please consider moving the private fields toprotected
to facilitate subclassing.At this time, those fields are
_points
,_hasStraightLine
, andoldEnd
.Thank you!
Current State
Currently not able to (cleanly) access private fields in a PencilBrush subclass.
Beta Was this translation helpful? Give feedback.
All reactions