Sabor Loja Mister #2305
Sabor Loja Mister #2305
Conversation
Summary: Also updated the changelog Reviewed By: samodom Differential Revision: D32785335 fbshipit-source-id: 0868e96d66e9da67fc7969500a7da1a1378050c2
Summary: We need to fix: 1. AEM Conversion Filetring endpoint/request names 2. Add special processing for content id 3. Combine catalog networker and AEM networker Reviewed By: wx0165927473, samodom Differential Revision: D32782549 fbshipit-source-id: c02e20d9ff7e116ecdba2c784a164a1831acb553
Summary: See updated changelog. Reviewed By: NSProgrammer Differential Revision: D32809771 fbshipit-source-id: cefc568518155628503d0a3f13994c978c688825
Summary: This diff cleans up the payload parsing logic. It makes it easy to add new keys we need to listen for when parsing a gaming entry url into a native game. To add a new listener: Add it to the keys list. Create a new delegate Method Check for the key in the GameEntryInfo and The third party app implemented the delegate method for said key If so call the delegate method. Reviewed By: jawwad Differential Revision: D32808171 fbshipit-source-id: 799cd3bb2b1214ec3821e2bd37d59a2a55d9cc93
Summary: In this diff we add a listener to look for a tournament ID and payload when a third party game is started from a FB entry point. Reviewed By: jawwad Differential Revision: D32808372 fbshipit-source-id: fa552730519e354b43eef601c65eaa92a06caf41
Summary: This adds two new API's to tournaments share update and post score. We need these APIs to allow from developers to trigger updating a tournament using an ID giving when the user enters a native game by clicking a tournament on FB. Reviewed By: jawwad Differential Revision: D32808504 fbshipit-source-id: b59b01411c66685a1927b9d5835f24cd7511a8e0
Reviewed By: wx0165927473 Differential Revision: D32846912 fbshipit-source-id: f9f2998e3cfe49369e003a0e33ddb865dbb0901c
…2.2.0 Reviewed By: joesus Differential Revision: D32874575 fbshipit-source-id: 9b7dbc9c50fdb0133180488c63a94998a255e59e
Signed-off-by: Sabor Loja Mister <[email protected]>
lia67884477
requested review from
joesus,
jingping2015 and
kalendae
as code owners
|
Hi @lia67884477! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Thanks for proposing a pull request!
To help us review the request, please complete the following:
bugfor bug fixes)Pull Request Details
Describe what you accomplished in this pull request (for example, what happens before the change, and after the change)
Test Plan
Test Plan: Add your test plan here