Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Replace shaping instead of delete/create #186

Open
zealws opened this issue Nov 17, 2015 · 2 comments
Open

Replace shaping instead of delete/create #186

zealws opened this issue Nov 17, 2015 · 2 comments
Labels
Milestone

Comments

@zealws
Copy link
Contributor

zealws commented Nov 17, 2015

We should be smarter about how we manage shaping. If someone calls shape twice the second call shouldn't unshape and re-shape, instead it should be smart and replace only the pieces that have changed.

This is pretty easy given the rich tc API we're using but the iptables API isn't as full featured so we'll have to be clever here.

Might depend on #173.

@zealws zealws added the atcd label Nov 17, 2015
@zealws zealws self-assigned this Nov 17, 2015
@zealws zealws added this to the 2.1 milestone Nov 17, 2015
@chantra
Copy link
Contributor

chantra commented Nov 25, 2015

the good thing about replacing is that we would not need to change the mark so iptables is not affected here

@chantra chantra assigned chantra and unassigned zealws Apr 4, 2016
@chantra
Copy link
Contributor

chantra commented Apr 4, 2016

I looked into this the other day and it was less straightforward that I expected. I should re-assess

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants