Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lego: Split "Ensure lego binary exists and has the correct version" task in two #86

Open
famedly-bot opened this issue Nov 17, 2021 · 0 comments
Labels
priority::5-medium progress::backlog The Refinement of the issue is completed and DoR for the Squad is fulfilled team:infrastructure

Comments

@famedly-bot
Copy link

In GitLab by @lrsksr on Nov 17, 2021, 04:43

The shell task at https://gitlab.com/famedly/company/devops/collections/base/-/blob/main/roles/lego/tasks/main.yml#L26 produces a fatal error if the binary does not exist that is ignored, but is irritating.

This should be avoidable by splitting it in two tasks, the first testing if the binary exists and the second (version check) only executed if the first succeeded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority::5-medium progress::backlog The Refinement of the issue is completed and DoR for the Squad is fulfilled team:infrastructure
Projects
None yet
Development

No branches or pull requests

1 participant