Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback plugin inception #88

Open
famedly-bot opened this issue Feb 1, 2023 · 3 comments
Open

Callback plugin inception #88

famedly-bot opened this issue Feb 1, 2023 · 3 comments

Comments

@famedly-bot
Copy link

In GitLab by @jcgruenhage on Feb 1, 2023, 09:40

Ansible callback plugins are not all that powerful. Stuff that can't be done right now:

  • chaining together pre-processors before handing it over to the callback plugin thats doing the actual logging
  • having multiple output streams, where some could be logging to files, some to stdout, etc pp

We'd like to evaluate whether writing a call-back plugin that implements these and then hands off the logging to another call-back plugin would help us for stuff like https://gitlab.com/famedly/infra/meta/-/issues/666

@famedly-bot
Copy link
Author

In GitLab by @jcgruenhage on Feb 1, 2023, 09:55

mentioned in issue undefined##undefined

@famedly-bot
Copy link
Author

In GitLab by @lrsksr on Feb 10, 2023, 12:16

Talked to David at the CfgMgmtCamp and he said it would probably have a big performance penalty. We need to evaluate this.

@famedly-bot
Copy link
Author

In GitLab by @jcgruenhage on Feb 20, 2023, 12:44

Performance is definitely a valid concern here, as we need to check each task return value against each secret, so that might not scale super well, that's true. I don't think it should be that bad though? We need to somehow make sure that we're only checking secrets that apply to the host the task was running against, not every secret, then we should be fine.

@CherryKitten CherryKitten removed progress::backlog The Refinement of the issue is completed and DoR for the Squad is fulfilled team:infrastructure priority::4-high labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants