Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zitadel abstraction is leaky #3

Open
tlater-famedly opened this issue Jul 22, 2024 · 0 comments
Open

zitadel abstraction is leaky #3

tlater-famedly opened this issue Jul 22, 2024 · 0 comments
Labels
tech debt Work on this should be planned according to tech debt policy Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality.

Comments

@tlater-famedly
Copy link
Contributor

tlater-famedly commented Jul 22, 2024

The zitadel crate has a lot of internal data structs which we just pub use since they're necessary for using various functions: https://github.com/famedly/zitadel-rust-client/blob/main/src/lib.rs#L53

This is not per-se a problem, but we should either fully commit and expose them in our Config (with adequate serde derivations) or cleanly hide them behind abstractions. The latter is obviously better practice, but the purpose of this crate is effectively just to tape over the sins of code generation, rather than to provide any real further abstraction, so that would be a lot of empty plumbing code.

We need to decide which way to go and follow that more consistently.

@tlater-famedly tlater-famedly added Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality. tech debt Work on this should be planned according to tech debt policy labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech debt Work on this should be planned according to tech debt policy Technical Debt This Issue is a technical debt. Mark issues with this label to have an overview of the code quality.
Projects
None yet
Development

No branches or pull requests

1 participant