Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 Maintained fork of the django-saml2-auth #171

Open
mostafa opened this issue Feb 8, 2022 · 11 comments
Open

🚀 Maintained fork of the django-saml2-auth #171

mostafa opened this issue Feb 8, 2022 · 11 comments

Comments

@mostafa
Copy link
Collaborator

mostafa commented Feb 8, 2022

Hey everyone,

I am maintaining a forked instance of the project at grafana/django-saml2-auth. I've merged many PRs, completely refactored the code, added tests and CI workflow and update dependencies fairly regularly. Please open your issues and PRs against my fork if you want and I'd be happy to review and eventually merge them.

Also, thanks @fangli and others for the great work you did on this project.

@mostafa mostafa changed the title Maintained fork of the django-saml2-auth 🚀 Maintained fork of the django-saml2-auth Feb 8, 2022
@dshinzie
Copy link

dshinzie commented Mar 4, 2022

@mostafa does your fork support Django 3.0+, as well as Python 3.10+?

@mostafa
Copy link
Collaborator Author

mostafa commented Mar 4, 2022

@dshinzie I haven't tested it, but it should work. Please create an issue on the fork, so I don't forget to test it.

@mostafa
Copy link
Collaborator Author

mostafa commented Mar 16, 2022

@dshinzie It now supports all the latest Django versions:
https://github.com/grafana/django-saml2-auth/releases/tag/v3.4.0

@suhailvs
Copy link

suhailvs commented Apr 1, 2024

i have created a documentation https://djangosaml.readthedocs.io/ with a very basic demo using https://mocksaml.com. May be we can create this doc in you repo https://github.com/grafana/django-saml2-auth/?

@mostafa
Copy link
Collaborator Author

mostafa commented Apr 1, 2024

Hey @suhailvs!

That would be awesome. Go for it! You can also add it as tests as explained on this issue.

@suhailvs
Copy link

suhailvs commented Apr 2, 2024

@mostafa hopes will look at it when i am free.

@mostafa
Copy link
Collaborator Author

mostafa commented Oct 9, 2024

@fangli Can you pin this issue?

@fangli
Copy link
Owner

fangli commented Oct 9, 2024

Hey @mostafa I can’t contribute to the project due to some restrictions but I added you as contributor. Feel free to help on maintaining the project. Thank you.

@mostafa mostafa pinned this issue Oct 9, 2024
@mostafa
Copy link
Collaborator Author

mostafa commented Oct 9, 2024

@fangli Thank you! 🙏
Can you add me to PyPI as well?

@fangli
Copy link
Owner

fangli commented Oct 9, 2024

@mostafa
Could you share your pypi username?

@mostafa
Copy link
Collaborator Author

mostafa commented Oct 9, 2024

@fangli
moradian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants