From 7dca45837e019193422fb45a939b494d149b7a5a Mon Sep 17 00:00:00 2001
From: Trevor Elliott <telliott@fastly.com>
Date: Tue, 18 Jun 2024 10:43:45 -0700
Subject: [PATCH] =?UTF-8?q?=F0=9F=94=A7=20Explicitly=20test=20the=20dictio?=
 =?UTF-8?q?nary=20host=20calls=20in=20the=20dictionary=20fixture=20(#390)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The dictionary fixture is using the ConfigStore api from the fastly crate, which uses the config-store host calls under the hood. To ensure that we're testing the dictionary host calls while they exist, this PR refactors the dictionary-lookup fixture to use the dictionary host calls directly.
---
 test-fixtures/src/bin/dictionary-lookup.rs | 45 +++++++++++++++++++---
 1 file changed, 40 insertions(+), 5 deletions(-)

diff --git a/test-fixtures/src/bin/dictionary-lookup.rs b/test-fixtures/src/bin/dictionary-lookup.rs
index 00fcf711..f3697740 100644
--- a/test-fixtures/src/bin/dictionary-lookup.rs
+++ b/test-fixtures/src/bin/dictionary-lookup.rs
@@ -1,10 +1,45 @@
 //! A guest program to test that dictionary lookups work properly.
 
-use fastly::ConfigStore;
+use fastly_shared::FastlyStatus;
 
 fn main() {
-    let animals = ConfigStore::open("animals");
-    assert_eq!(animals.get("dog").unwrap(), "woof");
-    assert_eq!(animals.get("cat").unwrap(), "meow");
-    assert_eq!(animals.get("lamp"), None);
+    let animals = unsafe {
+        let mut dict_handle = fastly_shared::INVALID_DICTIONARY_HANDLE;
+        let res = fastly_sys::fastly_dictionary::open(
+            "animals".as_ptr(),
+            "animals".len(),
+            &mut dict_handle as *mut _,
+        );
+        assert_eq!(res, FastlyStatus::OK, "Failed to open dictionary");
+        dict_handle
+    };
+
+    let get = |key: &str, buf_len: usize| unsafe {
+        let mut value = Vec::with_capacity(buf_len);
+        let mut nwritten = 0;
+        let res = fastly_sys::fastly_dictionary::get(
+            animals,
+            key.as_ptr(),
+            key.len(),
+            value.as_mut_ptr(),
+            buf_len,
+            &mut nwritten as *mut _,
+        );
+
+        if res != FastlyStatus::OK {
+            if res == FastlyStatus::NONE {
+                return Ok(None);
+            }
+
+            return Err(res);
+        }
+
+        value.set_len(nwritten);
+        value.shrink_to(nwritten);
+        Ok(Some(String::from_utf8(value).unwrap()))
+    };
+
+    assert_eq!(get("dog", 4).unwrap().unwrap(), "woof");
+    assert_eq!(get("cat", 4).unwrap().unwrap(), "meow");
+    assert_eq!(get("lamp", 4), Ok(None));
 }