Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimization (accessibility): [aria-hidden="true"] elements contain focusable descendants #4183

Closed
1 task
rfultz opened this issue Nov 5, 2020 · 1 comment · Fixed by #4456
Closed
1 task
Assignees
Milestone

Comments

@rfultz
Copy link
Contributor

rfultz commented Nov 5, 2020

Background

Looking to optimize the site's performance and that of the homepage specifically, the Lighthouse tool in Chromium browsers has made some suggestions. Some of these will have repercussions throughout the app so we're going to make them their own tickets.

Accessibility Recommendation: [aria-hidden="true"] elements contain focusable descendants

Focusable descendants within an [aria-hidden="true"] element prevent those interactive elements from being available to users of assistive technologies like screen readers. details

Overview

We should check aria-hidden attribute of #site-menu.site-nav__container

Benefit (the 80 of 80/20)

Significant if we're currently hiding our main nav from screen readers by default?

Effort (the 20 of 80/20)

Seemingly minimal

Complications

Will this change complicate layout in Chrome, etc—is there a reason it's like this?

Related tickets

This was referenced Nov 5, 2020
@JonellaCulmer JonellaCulmer added this to the Sprint 14.1 milestone Feb 17, 2021
@JonellaCulmer JonellaCulmer removed this from the Sprint 14.1 milestone Mar 9, 2021
@JonellaCulmer JonellaCulmer added this to the Sprint 14.2 milestone Mar 9, 2021
@JonellaCulmer
Copy link
Contributor

PR merged, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants