Skip to content
This repository has been archived by the owner on May 22, 2024. It is now read-only.

Incompatible package errors: django-rq, djangorestframework, and requests #541

Closed
2 tasks
Tracked by #137
lbeaufort opened this issue Nov 3, 2020 · 0 comments · Fixed by #558
Closed
2 tasks
Tracked by #137

Incompatible package errors: django-rq, djangorestframework, and requests #541

lbeaufort opened this issue Nov 3, 2020 · 0 comments · Fixed by #558

Comments

@lbeaufort
Copy link
Member

lbeaufort commented Nov 3, 2020

Task

Resolve errors listed below.

Example build

https://app.circleci.com/pipelines/github/fecgov/fec-eregs/145/workflows/ddc51387-b6eb-4955-9f51-c0b2a6121fee/jobs/483

Errors:

ERROR: django-rq 2.3.2 has requirement django>=2.0, but you'll have django 1.11.29 which is incompatible.
ERROR: djangorestframework 3.12.1 has requirement django>=2.2, but you'll have django 1.11.29 which is incompatible.

Possible options:

  • Pin dependencies to older version
  • Update Django version to django>=2.2 (probably too big of a task)

Technical considerations

  • This appears to be installed because requirements_dev.txt is getting installed in production. It may be okay to remove that from the build (we should test though, just to verify, alternatively, maybe these requirements are needed and belong in requirements.txt)
  • related-ish ticket to streamline eregs and clean up requirements: decide on path forward for eregs #513

Completion criteria

  • determine whether this is a problem for Production (or, say, it's only code we use locally)
  • We've solved the error or determined this is a won't fix for us (third-party code complications, etc)
@lbeaufort lbeaufort modified the milestones: Sprint 13.7, Sprint 13.8 Nov 3, 2020
@jason-upchurch jason-upchurch changed the title Incompatible package errors: django-rq and djangorestframework Incompatible package errors: django-rq, djangorestframework, and requests Nov 12, 2020
@jason-upchurch jason-upchurch self-assigned this Dec 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants