Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Update the Create a new report "FORM TYPE" dropdown #2460

Open
exalate-issue-sync bot opened this issue Dec 20, 2024 · 4 comments
Open

UI: Update the Create a new report "FORM TYPE" dropdown #2460

exalate-issue-sync bot opened this issue Dec 20, 2024 · 4 comments
Assignees
Labels

Comments

@exalate-issue-sync
Copy link

exalate-issue-sync bot commented Dec 20, 2024

In the "Create a new report" modal, the dropdown currently displays "Form 24: 24/48 hour notice of independent expenditure." This label should be updated to replace the word "notice" with "report" for consistency with other terminology

Task:

Change from: "Form 24: 24/48 hour notice of independent expenditure."

Change to: "Form 24: 24/48 hour report of independent expenditure."

QA Notes

This is the only place that should change - the label is not shared elsewhere in the application.

Outside the front-end change, devs will provide screenshots of updated labels in repositories.

DEV Notes

Steps to Reproduce:

Navigate to the FECFile application.

Click "Create report."

Open the form type dropdown.

Observe the label for Form 24.

Ensure that this does not break the E2E test - in addition, ensure that it is covered in the E2E test.

Design

Instead of it saying notice, it should say report.

!Screenshot 2024-12-20 at 12.59.11 PM.png|width=965,height=604,alt="Screenshot 2024-12-20 at 12.59.11 PM.png"!

See full ticket and images here: FECFILE-1911

Pull Request: #2493

@exalate-issue-sync exalate-issue-sync bot changed the title Update the label for Form 24 from "24/48 hour notice of independent expenditure" to "24/48 hour report of independent expenditure" UI: Update the Create a new report "FORM TYPE" dropdown Dec 20, 2024
Copy link
Author

Mitchell Jarrett commented: [~accountid:712020:3243085d-540a-4657-ad08-d891487882d0] [~accountid:61b0b42cd5986c006a9e1c94] Can you please review this ticket

Copy link
Author

Todd Lees commented: Passes CR moving to QA

Copy link
Author

exalate-issue-sync bot commented Jan 16, 2025

Shelly Wise commented: QA review verified the “Create a new report” Form 24 label in the dropdown has been changed from:

Form 24: 24/48 Hour Notice of Independent Expenditure

!image-20250116-173752.png|width=786,height=583,alt="image-20250116-173752.png"!

to:

Form 24: 24/48 Hour Report of Independent Expenditure

!image-20250116-173616.png|width=826,height=280,alt="image-20250116-173616.png"!

(Note: AC shows sentence case for dropdown, but the dropdown is initial caps as shown in above screenshots. Form 24: should also be bolded as shown in screenshots)

DEV to verify this change passes e2e tests.

QA Review Completed. Moved to Stage Ready.

Copy link
Author

Sasha Dresden commented: Updated with new PR with extra e2e assertion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant