Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove totals/by_party and totals/by_office (5026 follow-up) #5365

Closed
6 of 9 tasks
cnlucas opened this issue Mar 9, 2023 · 2 comments · Fixed by #5425 or #5446
Closed
6 of 9 tasks

Remove totals/by_party and totals/by_office (5026 follow-up) #5365

cnlucas opened this issue Mar 9, 2023 · 2 comments · Fixed by #5425 or #5446
Assignees
Milestone

Comments

@cnlucas
Copy link
Member

cnlucas commented Mar 9, 2023

What we’re after

After @fec-jli's work on the candidate/totals/aggregates endpoint here we should be able to remove the totals/by_office and totals/by_party endpoints. We need to conduct extensive testing to ensure the new endpoint will provide the same numbers as the old endpoint, ensure that our users are properly notified according to our policy, and then make the appropriate CMS changes so that it's pulling from the better and more flexible candidate/totals endpoint instead of the old endpoints. Then, we can remove the old endpoints.

Related ticket(s)

(Include the tickets that either came before, after, or are happening in tandem with this new ticket)

Action item(s)

(These are the smaller tasks that should happen in order to complete this work)

  • Test new vs old by_party and by_office totals
  • Fix any issues found in above testing
  • Ensure that there's no shared logic with the old endpoints
  • Switch over CMS
  • Notify Users
  • Give appropriate time for users/deprecate old endpoints
  • Deprecation notice added to endpoints add deprecation notice for by_office and by_office/by_party endpoints #5425
  • Remove old endpoints and remove deprecation notices
@cnlucas
Copy link
Member Author

cnlucas commented Apr 24, 2023

DEPRECATION NOTICE sent 4/24/2023 to all users of the endpoint in the last 120 days as is policy. Another notice will be sent on May 23, 2023 and the removal can be done after that date.

@cnlucas
Copy link
Member Author

cnlucas commented Apr 26, 2023

Re-opening to remember to send another notice and remove the endpoints

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment