Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete should not result in the target server fetching the Actor/Object if it does not already know about it #31

Open
ThisIsMissEm opened this issue Mar 8, 2024 · 2 comments
Labels
protocol-level A test that requires a Node that can craft / inspect in detail protocol-level data

Comments

@ThisIsMissEm
Copy link

As the action is to be deleting the data, the object shouldn't be first requested, but you do need to verify that the object is "owned" in some way (i.e., don't allow Delete(Object) where the Object.id is a different server to the Delete activity's origin.

This came up from a discussion with @dansup around how deletes work in pixelfed, where he wasn't sure if it was safe to send a Delete in certain cases due to the remote server potentially first fetching the object it's being told to delete.

@jernst jernst transferred this issue from fediverse-devnet/feditest Mar 11, 2024
@jernst
Copy link
Member

jernst commented Apr 24, 2024

I'm a little confused here. If [email protected] receives a Delete(X), presumably the software at a.example first checks whether it has a copy of X.

If it doesn't have a copy of X, nothing happens because there is nothing to delete.
If it does have a copy of X, it doesn't need to fetch X because it already has it.

What am I misunderstanding?

@ThisIsMissEm
Copy link
Author

Yup, but there's some fediverse software where receiving a Delete(X) actually triggers a fetch on X, which should be treated as an error (fediverse software should fetch something when receiving a Delete, if it doesn't know of that thing)

@jernst jernst added the protocol-level A test that requires a Node that can craft / inspect in detail protocol-level data label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol-level A test that requires a Node that can craft / inspect in detail protocol-level data
Projects
None yet
Development

No branches or pull requests

2 participants