Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Multiline info display in meeting minutes #700

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sopyb
Copy link
Contributor

@sopyb sopyb commented Mar 16, 2024

closes #687

Copy link
Member

@gridhead gridhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The said inclusion to the CSS causes bugs in the appearance and does not help with the issue.

image

Please note that the HTML format logs are taken into account for rendering them on the Meetbot so attempting to fix it there would make more sense.

Take, for instance -

  1. Here's how it is distinguished in just multiple lines here in the TXT file - https://meetbot-raw.fedoraproject.org//meeting-3_matrix_fedoraproject-org/2024-01-15/cpe-infra-releng-daily-standup.2024-01-15-08.30.txt

  2. But here in the HTML format of the information - they all coalesce to one line - https://meetbot-raw.fedoraproject.org//meeting-3_matrix_fedoraproject-org/2024-01-15/cpe-infra-releng-daily-standup.2024-01-15-08.30.html

@sopyb sopyb force-pushed the fix-multiline-info branch from 677c497 to 8511889 Compare January 4, 2025 19:50
@sopyb
Copy link
Contributor Author

sopyb commented Jan 4, 2025

Hey sorry it's been a while, I totally forgot I opened this pull request. I accidentally commited pre-line instead of pre-word. Now it should be fine. I looked for the meeting that was rendering weird in browser and found it. (here)

I also checked a lot of other minutes from fedora-meeting, meeting_matrix_fedoraproject-org and meeting-3_matrix_fedoraproject-org.

Let me know if any other issues arise.

@sopyb sopyb requested a review from gridhead January 4, 2025 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiline info lines are represented as a single line in the minutes.
2 participants