Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

222 refactor scalability and outputs #223

Open
wants to merge 117 commits into
base: master
Choose a base branch
from

Conversation

JavierCladellas
Copy link
Collaborator

@JavierCladellas JavierCladellas commented Feb 4, 2025

Done:

  • Refactored scalability: There is no longer a outputs field, nor an OutputsHandler.
  • Refactored the code that copies partials (now on AppSetup
  • Created an Extractor Factory for extracting performance variables from different file formats (currently: json, csv, tsv [toolbox specific] ) .
  • For perfvars in json files, the use of multiple wildcards (*) is now supported. [This is huge for handling KUB timers]
  • Now users can specify custom units. The syntax is :
  "format":"csv"
  "units": {
    "*": "s",
    "my-column" : "my-special-unit"
  }
}

Implying that all columns on the csv will have "s" as unit, except the column my-column, which will have "my-special-unit" as unit.

  • Add option to scalability field to cleanup scalability directory after test: clean_directory. (defaults to false)

❗ Merge after #215

@JavierCladellas JavierCladellas added enhancement A new feature or request benchmarking Issues related to benchmarking refactor Refactoring code to improve structure or maintainability labels Feb 4, 2025
@JavierCladellas JavierCladellas self-assigned this Feb 4, 2025
@JavierCladellas JavierCladellas linked an issue Feb 4, 2025 that may be closed by this pull request
5 tasks
Copy link

netlify bot commented Feb 4, 2025

Deploy Preview for benchmarking-polite-crostata-92f389 ready!

Name Link
🔨 Latest commit c30a6cb
🔍 Latest deploy log https://app.netlify.com/sites/benchmarking-polite-crostata-92f389/deploys/67a23e672547b900082b68d8
😎 Deploy Preview https://deploy-preview-223--benchmarking-polite-crostata-92f389.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@JavierCladellas JavierCladellas marked this pull request as ready for review February 4, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
benchmarking Issues related to benchmarking enhancement A new feature or request refactor Refactoring code to improve structure or maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor scalability and outputs Clean application outputs
1 participant