Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AbstractFileReference>>#deleteAll crashes the VM on Windows when a GtFileWatcherEventLoop / GtFileWatcher is active #3917

Closed
svenvc opened this issue Jul 19, 2024 · 3 comments
Assignees
Labels

Comments

@svenvc
Copy link
Contributor

svenvc commented Jul 19, 2024

AbstractFileReference>>#deleteAll crashes the VM on Windows when a GtFileWatcherEventLoop / GtFileWatcher is active.

Here are two snippets (just DoIt is enough):

(FileLocator home / 'MyDir') in: [ :myDir | 
	myDir ensureCreateDirectory.
	myDir watcher.
	myDir deleteAll ]

and

dir := (FileLocator imageDirectory / 'xxx') resolve.
dir ensureCreateDirectory.
watcher := dir watcher.
dir deleteAll

while the following work:

(FileLocator home / 'MyDir') ensureCreateDirectory; deleteAll

and

((FileLocator temp / 'MyDir' / 'MyFile.txt') ensureCreateFile; parent) deleteAll

Note: this is Windows specific, this works on macOS and Linux.

@svenvc
Copy link
Contributor Author

svenvc commented Jul 19, 2024

notify-rs/notify#403

@hellerve hellerve self-assigned this Jul 20, 2024
@hellerve hellerve added the bug label Jul 20, 2024
@hellerve
Copy link
Member

This is fixed as of v1.0.1451. There are multiple changes and refactorings that have happened in filewatcher, but the important part for this bug was an upgrade of the notify crate to 8.0.0 (notify-rs/notify#624 was the root cause).

@svenvc
Copy link
Contributor Author

svenvc commented Jan 16, 2025

Thank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants