Likelihood scan() crashes if fix_src_pars=True

[ricrando]

There are 2 problems:
the first is a self.like.freePars() instead of just self.freePars():

File ".../AnalysisBase.py", line 795, in scan
    freePars = self.like.freePars(srcName)
AttributeError: 'BinnedAnalysis' object has no attribute 'like'

the second is a 0 instead of a False

File ".../AnalysisBase.py", line 796, in scan
   self.setFreeFlag(srcName, freePars, 0)
 File ".../AnalysisBase.py", line 712, in setFreeFlag
   src_spectrum.parameter(item.getName()).setFree(value)
 File ".../pyLikelihood.py", line 2505, in setFree
   return _pyLikelihood.Parameter_setFree(self, free)
TypeError: in method 'Parameter_setFree', argument 2 of type 'bool'

[ricrando]

Pull request

[donhorner]

Do you have an example we can use as a test case?

[ricrando]

Sure, here is a sample script using the datafiles in the binned likelihd tutorial:
https://fermi.gsfc.nasa.gov/ssc/data/analysis/scitools/binned_likelihood_tutorial.html
The script:
doscan.py.txt

[joeastro]

I was able to reproduce both issues @ricrando found using the test case provided above, and the proposed fixes seem both sensible & solved the underlying issues. I recommend approving the request.