Shiftit doesn't work with two monitors if one is in Fullscreen mode #274

dylnclrk · 2018-02-26T21:33:09Z

Problem:

I can't use Shiftit when one of my monitors is in full-screen mode.

More detail:

I have two monitors set up today. In one monitor I have Terminal.app running in full-screen mode, in the other I have several applications (including Chrome) running in regular, windowed mode.

When trying to resize the focused Chrome window, nothing happens, and I see,

2018-02-26 13:27:23.813 ShiftIt[31982/0x7fffb50e1340] [lvl=3] -[ShiftItAppDelegate invokeShiftItActionByIdentifier_:] Execution of ShiftIt action: right failed: Windows in fullscreen are not supported
NSError stack trace:
org.shiftitapp.shifit.error:20103 - Windows in fullscreen are not supported

in the debug log.

So it seems like it's trying to resize my full-screened Terminal window.

Workaround:

Take Terminal out of full-screen mode, and everybody's happy. Shiftit works.

The text was updated successfully, but these errors were encountered:

fikovnik · 2018-02-26T22:53:30Z

Which version do you use - try the latest from homebrew - should work.

dylnclrk · 2018-02-26T23:35:55Z

@fikovnik I tried updating (via homebrew cask) before posting this bug report. Unfortunately I'm still seeing the issue on 1.6.5 (and Mac OS 10.13.3).

Oddly enough, I also noticed an inconsistency in the reported version number… see #275 when I clicked "Check for updates". So maybe I'm messing something up with the update?

I wish I were more handy with OS X so I could do a better job helping with these issues.

Let me know if there's anything else I can do to help triage.

nikcorg · 2018-03-02T10:43:17Z

Ditto for this issue on OS X 10.12.6 and ShiftIt 1.6.6.

emptylambda · 2018-03-02T13:27:40Z

Same issue with OSX 10.13 and ShiftIt 1.6.3.
And I've noticed that this issue only occurs when terminal-based application running fullscreen (including Terminal and iTerm2). If you fullscreen other types of application (i.e. browser / finder / iTunes ..) this block would not happen!

dylnclrk · 2018-03-02T18:38:20Z

I updated to Shiftit 1.6.6, and I'm still seeing this issue. As @emptylambda says it seems to be somewhat inconsistent and depend on the application that's full-screened.

Some Scenarios (ShiftIt 1.6.6 & MacOS 10.13.3 supplimental)

Fullscreened application: Safari
Windowed application on other screen: Chrome/Terminal.app/Spotify/Safari
Behavior: Works as normal

Fullscreen: Terminal.app
Windowed: Chrome/Spotify/Safari
Behavior: Doesn't work. But if there is a terminal.app window in the background of the windowed screen, it gets resized (even if you have focus in another application).

Fullscreen: Chrome
Windowedn: Spotify/Terminal.app/Safari
Behavior: Doesn't work. But if there is a Chrome window in the background of the windowed screen, it gets resized (even if you have focus in another application).

fosron · 2018-03-05T08:43:13Z

Getting this with 3 monitors (1 - Slack in fullscreen, 2 - App i want to maximize with ShiftIt, 3 - PHPStorm);

macOS 10.13.2 + ShiftIt 1.6.6

2018-03-05 10:39:56.791 ShiftIt[20848/0x7fff88491340] [lvl=3] -[ShiftItAppDelegate invokeShiftItActionByIdentifier_:] Execution of ShiftIt action: maximize failed: Windows in fullscreen are not supported
NSError stack trace:
org.shiftitapp.shifit.error:20103 - Windows in fullscreen are not supported

emptylambda · 2018-03-07T11:29:52Z

Im looking into the codebase for this, it seems like Terminal-like app automagically obtains the highest priority for CFWindows list and will always get chosen as if it is "focused" windows.

Therefore once any Terminal-like application gets into fullscreen mode, any other ShiftIt action could not be performed despite our focus and intention is for another application's window.
Baseline logic is not wrong: a fullscreen window should not be able to shift left or right anymore.

I pin down the issue currently located in file SIWindowManager.m the function getFocusedWindow (around line 144).

Since Im not familiar with Core, my fix may take a bit longer but Im trying to mend this :)

nikcorg · 2018-03-07T12:20:45Z

I can repeat the behaviour with any full screen app, not just terminal (iTerm2).

I switched to Spectacle.app which doesn't have this problem.

aguynamedben · 2018-04-06T17:27:27Z

This is happening to me too. MacOS 10.13.3, ShiftIt 1.6.6. MacBook Pro with 4k Dell monitor hooked up. Trying to work on the 4k monitor and watch The Masters on the MacBook Pro display. 🖥⛳️

Thanks to the ShiftIt team for the hard work developing this free app. 👏

nikcorg · 2018-04-09T13:14:59Z

Thanks to the ShiftIt team for the hard work developing this free app. 👏

Seconded. I failed to mention in my previous comment that my switch was reluctant. Apart from being a great app otherwise, ShiftIt has a universal shortcut to fullscreen an app on OSX, which for some strange reason doesn't have a standard OS level shortcut.

UrGuardian4ngel · 2018-04-13T02:17:36Z

ShiftIt has a universal shortcut to fullscreen an app on OSX, which for some strange reason doesn't have a standard OS level shortcut.

@nikcorg Doesn't it? Well, maybe not a standard one.
But, nothing's stopping you from customizing your system, and creating one yourself?

Seems like you can simply create your own custom shortcut for that. As a matter of fact, you can create your own shortcuts for any macOS app (separately), just by adding a menu item's title, and hitting a shortcut?

System Preferences > Keyboard > Shortcuts

nikcorg · 2018-04-17T11:02:22Z

@UrGuardian4ngel yes, I've set that keyboard shortcut, but despite that all apps don't adhere to it. E.g. iTerm listens to command-enter, VS Code listens to ctrl-command-f.

UrGuardian4ngel · 2018-04-18T17:30:02Z

Hmm... For me, both seem to work?

my "custom" cmd + ctrl + alt + F keybinding
and the "application default", like cmd + enter for e.g. iTerm

I'm on macOS 10.13.3.

Just wondering, the menu title in preferences is case sensitive.
So it should match the menu title exactly...

nikcorg · 2018-04-20T09:21:02Z

@UrGuardian4ngel I noticed in iTerm the menu item is actually called Toggle Full Screen, which is why it didn't match. Fixed and now it works. So yet another case of PEBKAC. :-)

hadidotj · 2018-04-20T13:09:10Z

FYI, it appears PR #276 fixes this issue, for those who wish to build locally.
Quit ShiftIt, then run below to patch:

git clone https://github.com/fikovnik/ShiftIt
cd ShiftIt
git checkout master
curl https://patch-diff.githubusercontent.com/raw/fikovnik/ShiftIt/pull/276.diff > fix.patch
git apply fix.patch
cd ShiftIt
xcodebuild -target "ShiftIt NoX11" -configuration Release
rm -rf /Applications/ShiftIt.app
cp -R build/Release/ShiftIt.app /Applications
open /Applications/ShiftIt.app

elijahcarrel · 2018-08-09T23:18:11Z

Note that for those of you who are not mac or iOS developers but are trying to apply the patch, the Xcode tools need to be installed and Xcode needs to have been opened at least once in order for the xcodebuild statement that @hadidotj mentioned above to work. If you (like me) downloaded Xcode to run that statement but did not open it, running the above code leads to the unhelpful error message "Command /Applications/Xcode.app/Contents/Developer/usr/bin/ibtool failed with exit code 6. The tool may have crashed."

DannyDannyDanny · 2018-08-10T09:09:22Z

Solution for `tool 'xcodebuild' requires Xcode`

When running xcodebuild -target "ShiftIt NoX11" -configuration Release you may get the error:

tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

To get around this:

Install Xcode from App Store
Open Xcode, finish install, accept license
Point Xcode-select to the right directory sudo xcode-select -s /Applications/Xcode.app/Contents/Developer
Go back to following instruction by @hadidotj

Credit to this stackoverflow thread

holmesmi · 2018-08-22T12:10:47Z

Question: if I have multiple monitors, and some windows in full-screen mode, should I be able to use the "Next" and "Previous" shortcuts, or are they intended to only work on windowed apps? I don't know if I should file a feature request or a bug report....

jaggerwang · 2018-09-04T02:28:44Z

Came into the same problem when open a fullscreen Chrome window on my second monitor, it became ok when exit fullscreen mode. And it is also ok to open a fullscreen Chrome window on my first monitor.

2018-09-04 10:19:28.355 ShiftIt[5569/0x7fff97844380] [lvl=3] -[ShiftItAppDelegate invokeShiftItActionByIdentifier_:] Execution of ShiftIt action: maximize failed: Windows in fullscreen are not supported
NSError stack trace:
org.shiftitapp.shifit.error:20103 - Windows in fullscreen are not supported
2018-09-04 10:19:48.602 ShiftIt[5569/0x7fff97844380] [lvl=3] -[ShiftItAppDelegate invokeShiftItActionByIdentifier_:] Execution of ShiftIt action: maximize failed: Windows in fullscreen are not supported
NSError stack trace:
org.shiftitapp.shifit.error:20103 - Windows in fullscreen are not supported

MladenJanjetovic · 2018-10-30T12:08:58Z

Same here, I had this issue but didn't realize that it has something to do with Full screen mode on one of the screens. Thanks

FugueSoft · 2021-09-03T23:10:47Z

Same here for me running 10.14.6 with ShiftIt 1.6.6

Note
It appears this issue is a duplicate of a previous issue

holmesmi · 2021-09-05T11:23:38Z

Same here for me running 10.14.6 with ShiftIt 1.6.6

Note
It appears this issue is a duplicate of a previous issue

It appears ShiftIt has been abandoned. I'm using https://rectangleapp.com/ for the same purpose, and it works great.

vitalibozhko pushed a commit to vitalibozhko/ShiftIt that referenced this issue Mar 9, 2018

Fixes fikovnik#274

b3c203e

hadidotj mentioned this issue Apr 20, 2018

Fixes #274 and #230 #276

Open

osis mentioned this issue Aug 24, 2018

In the latest MacOs Version ShiftIt doesn't work #279

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Shiftit doesn't work with two monitors if one is in Fullscreen mode #274

Shiftit doesn't work with two monitors if one is in Fullscreen mode #274

dylnclrk commented Feb 26, 2018

fikovnik commented Feb 26, 2018

dylnclrk commented Feb 26, 2018

nikcorg commented Mar 2, 2018

emptylambda commented Mar 2, 2018 •

edited

Loading

dylnclrk commented Mar 2, 2018 •

edited

Loading

fosron commented Mar 5, 2018

emptylambda commented Mar 7, 2018 •

edited

Loading

nikcorg commented Mar 7, 2018

aguynamedben commented Apr 6, 2018

nikcorg commented Apr 9, 2018

UrGuardian4ngel commented Apr 13, 2018 •

edited

Loading

nikcorg commented Apr 17, 2018 •

edited

Loading

UrGuardian4ngel commented Apr 18, 2018 •

edited

Loading

nikcorg commented Apr 20, 2018

hadidotj commented Apr 20, 2018 •

edited

Loading

elijahcarrel commented Aug 9, 2018 •

edited

Loading

DannyDannyDanny commented Aug 10, 2018

holmesmi commented Aug 22, 2018

jaggerwang commented Sep 4, 2018

MladenJanjetovic commented Oct 30, 2018

FugueSoft commented Sep 3, 2021

holmesmi commented Sep 5, 2021

Shiftit doesn't work with two monitors if one is in Fullscreen mode #274

Shiftit doesn't work with two monitors if one is in Fullscreen mode #274

Comments

dylnclrk commented Feb 26, 2018

Problem:

More detail:

Workaround:

fikovnik commented Feb 26, 2018

dylnclrk commented Feb 26, 2018

nikcorg commented Mar 2, 2018

emptylambda commented Mar 2, 2018 • edited Loading

dylnclrk commented Mar 2, 2018 • edited Loading

Some Scenarios (ShiftIt 1.6.6 & MacOS 10.13.3 supplimental)

fosron commented Mar 5, 2018

emptylambda commented Mar 7, 2018 • edited Loading

nikcorg commented Mar 7, 2018

aguynamedben commented Apr 6, 2018

nikcorg commented Apr 9, 2018

UrGuardian4ngel commented Apr 13, 2018 • edited Loading

nikcorg commented Apr 17, 2018 • edited Loading

UrGuardian4ngel commented Apr 18, 2018 • edited Loading

nikcorg commented Apr 20, 2018

hadidotj commented Apr 20, 2018 • edited Loading

elijahcarrel commented Aug 9, 2018 • edited Loading

DannyDannyDanny commented Aug 10, 2018

Solution for tool 'xcodebuild' requires Xcode

holmesmi commented Aug 22, 2018

jaggerwang commented Sep 4, 2018

MladenJanjetovic commented Oct 30, 2018

FugueSoft commented Sep 3, 2021

holmesmi commented Sep 5, 2021

emptylambda commented Mar 2, 2018 •

edited

Loading

dylnclrk commented Mar 2, 2018 •

edited

Loading

emptylambda commented Mar 7, 2018 •

edited

Loading

UrGuardian4ngel commented Apr 13, 2018 •

edited

Loading

nikcorg commented Apr 17, 2018 •

edited

Loading

UrGuardian4ngel commented Apr 18, 2018 •

edited

Loading

hadidotj commented Apr 20, 2018 •

edited

Loading

elijahcarrel commented Aug 9, 2018 •

edited

Loading

Solution for `tool 'xcodebuild' requires Xcode`