Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error during user action currently crashes the app #1291

Open
naleeha opened this issue Apr 17, 2024 · 1 comment
Open

Error during user action currently crashes the app #1291

naleeha opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
bug Something isn't working server

Comments

@naleeha
Copy link
Contributor

naleeha commented Apr 17, 2024

Bug Report

Steps to Reproduce:

When things error - e.g rpc call, need to capture exception and return useful response rather than crashing the app. Currently this is open for individual VUU app developer and every function to implement

Could we have more centralize solution for error handling - for example have one around every RPC call?

Additional Context:

If we want rpc implementor to customise the error message,, could use something like a result pattern (Either in Scala) which returns a success and error result that are of different types

@naleeha naleeha added bug Something isn't working server labels Apr 17, 2024
@naleeha naleeha moved this to 🆕 New in Vuu board Apr 17, 2024
@naleeha naleeha moved this from 🆕 New to 📋 Backlog in Vuu board Apr 17, 2024
@naleeha naleeha moved this from 📋 Backlog to 🆕 New in Vuu board Apr 17, 2024
@keikeicheung keikeicheung moved this from 🆕 New to 🏗 In progress in Vuu board May 13, 2024
@keikeicheung keikeicheung moved this from 🏗 In progress to 🆕 New in Vuu board Jul 17, 2024
@naleeha
Copy link
Contributor Author

naleeha commented Aug 27, 2024

Might be best to wait for new RPC message type & RPC handler implementation on server side
Related Discussion #1447
Being tackled as part of this change #1434

  • New RPC response will have standard way to report error & more extendable format
  • New RPC handler implementation may already handle any error during RPC handling - see if more error/edge case handling is required
  • May want to introduce event based message to report back server side errors that are not in response to request - e.g. auth token validation failures/ expiry, connection being dropped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working server
Projects
Status: 🆕 New
Development

No branches or pull requests

2 participants