Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve Messaging token until a Listener is set #1634

Merged
merged 2 commits into from
Aug 20, 2024

Conversation

a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

Preserve the Messaging token if one is received when a Listener isn't set, and then send that token to the Listener when it is set. Normally we recommend setting the Listener with Initialize, which avoids this issue, but there are some use cases, like the Unity SDK, where there is a gap of time between Initialize and SetListener.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running the Unity testapp locally


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@a-maurice a-maurice added the tests-requested: quick Trigger a quick set of integration tests. label Aug 15, 2024
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests-requested: quick Trigger a quick set of integration tests. labels Aug 15, 2024
Copy link

github-actions bot commented Aug 15, 2024

✅  Integration test succeeded!

Requested by @jonsimantov on commit 66a9570
Last updated: Tue Aug 20 11:26 PDT 2024
View integration test log & download artifacts

@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 16, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 16, 2024
@a-maurice a-maurice requested a review from jonsimantov August 19, 2024 17:09
@jonsimantov jonsimantov merged commit 66a9570 into main Aug 20, 2024
64 of 65 checks passed
@github-actions github-actions bot added tests: in-progress This PR's integration tests are in progress. and removed tests: succeeded This PR's integration tests succeeded. labels Aug 20, 2024
@a-maurice a-maurice deleted the am-messaging_token_issue branch August 20, 2024 17:39
@github-actions github-actions bot added the tests: succeeded This PR's integration tests succeeded. label Aug 20, 2024
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Aug 20, 2024
@firebase firebase locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests: succeeded This PR's integration tests succeeded.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants