From f158dd9acee887a91f1a1bbdde4074200385c6da Mon Sep 17 00:00:00 2001
From: Thomas Bouldin <inlined@google.com>
Date: Mon, 3 Feb 2025 15:27:52 -0800
Subject: [PATCH] Revert "fix(js): Make flow.run's first parameter optional"

This reverts commit 46aa16a0e2143233847d172fde2c3b7f5daf8648.
---
 js/genkit/src/genkit.ts | 10 +++------
 js/pnpm-lock.yaml       | 46 +++++++++++++++++++++++++++++++++++++++++
 2 files changed, 49 insertions(+), 7 deletions(-)

diff --git a/js/genkit/src/genkit.ts b/js/genkit/src/genkit.ts
index 6f8cfbfab..8795cc6bb 100644
--- a/js/genkit/src/genkit.ts
+++ b/js/genkit/src/genkit.ts
@@ -222,7 +222,7 @@ export class Genkit implements HasRegistry {
     options: DefineModelOptions<CustomOptionsSchema>,
     runner: (
       request: GenerateRequest<CustomOptionsSchema>,
-      sendChunk?: StreamingCallback<GenerateResponseChunkData>
+      streamingCallback?: StreamingCallback<GenerateResponseChunkData>
     ) => Promise<GenerateResponseData>
   ): ModelAction<CustomOptionsSchema> {
     return defineModel(this.registry, options, runner);
@@ -721,9 +721,7 @@ export class Genkit implements HasRegistry {
    * A flow step that executes the provided function. Each run step is recorded separately in the trace.
    *
    * ```ts
-   * ai.defineFlow({
-   *   name: 'hello'
-   * }, async() => {
+   * ai.defineFlow('hello', async() => {
    *   await ai.run('step1', async () => {
    *     // ... step 1
    *   });
@@ -740,9 +738,7 @@ export class Genkit implements HasRegistry {
    * A flow step that executes the provided function. Each run step is recorded separately in the trace.
    *
    * ```ts
-   * ai.defineFlow({
-   *   name: 'hello'
-   * }, async() => {
+   * ai.defineFlow('hello', async() => {
    *   await ai.run('step1', async () => {
    *     // ... step 1
    *   });
diff --git a/js/pnpm-lock.yaml b/js/pnpm-lock.yaml
index a2d56992b..412999447 100644
--- a/js/pnpm-lock.yaml
+++ b/js/pnpm-lock.yaml
@@ -1496,6 +1496,52 @@ importers:
         specifier: ^5.6.2
         version: 5.6.3
 
+  testapps/personal-testing:
+    dependencies:
+      '@genkit-ai/firebase':
+        specifier: workspace:*
+        version: link:../../plugins/firebase
+      '@genkit-ai/google-cloud':
+        specifier: workspace:*
+        version: link:../../plugins/google-cloud
+      '@genkit-ai/googleai':
+        specifier: workspace:*
+        version: link:../../plugins/googleai
+      '@genkit-ai/vertexai':
+        specifier: workspace:*
+        version: link:../../plugins/vertexai
+      '@google/generative-ai':
+        specifier: ^0.15.0
+        version: 0.15.0
+      '@opentelemetry/sdk-trace-base':
+        specifier: ^1.25.0
+        version: 1.26.0(@opentelemetry/api@1.9.0)
+      body-parser:
+        specifier: ^1.20.3
+        version: 1.20.3
+      express:
+        specifier: ^4.21.0
+        version: 4.21.1
+      firebase-admin:
+        specifier: '>=12.2'
+        version: 12.3.1(encoding@0.1.13)
+      genkit:
+        specifier: workspace:*
+        version: link:../../genkit
+      partial-json:
+        specifier: ^0.1.7
+        version: 0.1.7
+    devDependencies:
+      rimraf:
+        specifier: ^6.0.1
+        version: 6.0.1
+      tsx:
+        specifier: ^4.19.2
+        version: 4.19.2
+      typescript:
+        specifier: ^5.3.3
+        version: 5.6.3
+
   testapps/prompt-file:
     dependencies:
       '@genkit-ai/googleai':