Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go] missing tracing metadata #225

Open
2 tasks
pavelgj opened this issue May 23, 2024 · 3 comments · Fixed by #1188 · May be fixed by #1845
Open
2 tasks

[Go] missing tracing metadata #225

pavelgj opened this issue May 23, 2024 · 3 comments · Fixed by #1188 · May be fixed by #1845
Assignees
@pavelgj @hugoaguirre
Labels
bug Something isn't working go
Milestone
go-0.2.0

Comments

@pavelgj
Copy link
Collaborator

pavelgj commented May 23, 2024

When Go runtime logs OT spans it's missing these things...

  • genkit:state is not set -- this is perhaps OK, it may be redundant -- can be inferred from span.status field, consider deprecating it on JS side as well.
  • genkit:metadata:subtype is not set for various action types (e.g. model, retriever, etc)
@pavelgj pavelgj added bug Something isn't working go labels May 23, 2024
@pavelgj pavelgj self-assigned this May 23, 2024
@chrisraygill chrisraygill added this to the go-0.2.0 milestone Jul 19, 2024
@falonso81
Copy link
Contributor

JS.json
go.json

@apascal07
I just compared them in ´next´ branch and they have the same tracing metadata, however when error, we are missing the status.description, this MR fix that https://github.com/firebase/genkit/pull/1188/files

@falonso81 falonso81 linked a pull request Feb 4, 2025 that will close this issue
Fix: display error in inspect page #1188
Merged
1 task
@yesudeep
Copy link
Contributor

yesudeep commented Feb 4, 2025

@alonsopec89 please add unit tests to ensure this feature works as intended.

@falonso81 falonso81 linked a pull request Feb 5, 2025 that will close this issue
Open
3 tasks
@falonso81
Copy link
Contributor

falonso81 commented Feb 5, 2025 •
edited
Loading

@alonsopec89 please add unit tests to ensure this feature works as intended.

@yesudeep
yes, I just push #1845

@hugoaguirre hugoaguirre linked a pull request Feb 5, 2025 that will close this issue
fix:(go/core/tracing) doing enhancements for unit test in span data #1845
Open
3 tasks
@hugoaguirre hugoaguirre assigned hugoaguirre and unassigned falonso81 Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pavelgj pavelgj

@hugoaguirre hugoaguirre

Labels
bug Something isn't working go
Projects
Genkit Backlog
Status: No status
Milestone
go-0.2.0
5 participants
@yesudeep @pavelgj @hugoaguirre @chrisraygill @falonso81