Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't block operating systems #41

Open
jwbensley opened this issue Aug 14, 2024 · 1 comment
Open

Don't block operating systems #41

jwbensley opened this issue Aug 14, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@jwbensley
Copy link

When I try to use the service I am blocked with the following message:

Ubuntu is not supported. Try viewing the results instead.

Is Ubuntu confirmed as not working or have you simply not tested it? What about all other OS's in existence, are they all blocked excepted for tested OS's?

It would be good if a warning was displayed instead of being blocked, "this operating system is untested or unsupported", and at least we we could try. This would then allow people to report to you "I used OS XYZ and it worked!".

@jamilbk
Copy link
Member

jamilbk commented Aug 21, 2024

Hi @jwbensley! Thanks for the report - this is simply a bug in our detection script, which looks for Linux. Happy to accept a PR to fix it or I'll get around to fix when I have some time freed up.

See here: https://github.com/firezone/probe/blob/main/lib/probe/live/component/run.ex#L26

@jamilbk jamilbk added bug Something isn't working good first issue Good for newcomers labels Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants