Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JournalFunction returns wrong version information #319

Open
saschaknapp opened this issue Jul 9, 2024 · 3 comments
Open

JournalFunction returns wrong version information #319

saschaknapp opened this issue Jul 9, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@saschaknapp
Copy link
Contributor

Background

The journal endpoint http://localhost:1500/json/v0/Journal?type=0 returns information about the middleware version.
ftJournalType: 0x0000000000000000

Describe the bug

Calling this journalType in 1.3.59 returns the following:
"Assembly":"fiskaltrust.Middleware.Queue, Version=1.3.0.0, Culture=neutral, PublicKeyToken=null","Version":{"Major":1,"Minor":3,"Build":0,"Revision":0,"MajorRevision":0,"MinorRevision":0}}

Shouldn't the build be 59 ?

@saschaknapp saschaknapp added the bug Something isn't working label Jul 9, 2024
@StefanKert
Copy link
Member

@volllly when improving the build process we should take a look at that. I am not sure if this will be a problem in FR since we focus on major.minor for certifications there (@Bluette-C-Riviere probably you can help us out here).

@Bluette-C-Riviere
Copy link
Contributor

Hello @StefanKert and @volllly

In my opinion this should not affect the certification, as the certified version of the middleware is 1.2.x, where x > 0.
If we want to be extra cautious, we can always use a self-attestation.

@StefanKert
Copy link
Member

Thanks @Bluette-C-Riviere. So in that case we should be good to include the detailed version in the payload.

@StefanKert StefanKert added this to the Next milestone milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants