From 7ccbf4ac55e5371a502bd9303c4e70755cf26cff Mon Sep 17 00:00:00 2001 From: Jamie Rodriguez <65564846+fivetran-jamie@users.noreply.github.com> Date: Thu, 23 May 2024 14:30:05 -0700 Subject: [PATCH] more docs and remove second reviewer bot --- .github/workflows/add-2nd-reviewer.yml | 10 ---------- CHANGELOG.md | 2 ++ 2 files changed, 2 insertions(+), 10 deletions(-) delete mode 100644 .github/workflows/add-2nd-reviewer.yml diff --git a/.github/workflows/add-2nd-reviewer.yml b/.github/workflows/add-2nd-reviewer.yml deleted file mode 100644 index 3f056aa..0000000 --- a/.github/workflows/add-2nd-reviewer.yml +++ /dev/null @@ -1,10 +0,0 @@ -name: '2nd reviewer' -on: - pull_request_review: - types: [submitted] - -jobs: - auto_assign_reviewer: - if: github.event.review.state == 'approved' - uses: fivetran/dbt_package_automations/.github/workflows/add-2nd-reviewer.yml@main - secrets: inherit \ No newline at end of file diff --git a/CHANGELOG.md b/CHANGELOG.md index 240046e..a6e4a73 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,8 @@ Introducing...conversion metrics ([PR #43](https://github.com/fivetran/dbt_faceb ## Under the Hood - Updated the `quickstart.yml` file to allow for automated Quickstart data model deployments ([PR #40](https://github.com/fivetran/dbt_facebook_ads/pull/40)). - Updated the PR templates to align with our most up-to-date standards ([PR #43](https://github.com/fivetran/dbt_facebook_ads/pull/43)). +- Removed the now-defunct 2nd reviewer bot workflow ([PR #43](https://github.com/fivetran/dbt_facebook_ads/pull/43)). +- Added a new [version](https://github.com/fivetran/dbt_facebook_ads/blob/main/macros/facebook_ads_persist_pass_through_columns.sql) of the `persist_pass_through_columns()` [macro](https://github.com/fivetran/dbt_fivetran_utils/blob/v0.4.10/macros/persist_pass_through_columns.sql) in which we can include `coalesces`. ## Contributors [Seer Interactive](https://www.seerinteractive.com/)