Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed API #125

Open
tamasfe opened this issue Jan 13, 2025 · 2 comments
Open

Typed API #125

tamasfe opened this issue Jan 13, 2025 · 2 comments
Labels
api enhancement New feature or request epic good first issue Good for newcomers help wanted Extra attention is needed

Comments

@tamasfe
Copy link

tamasfe commented Jan 13, 2025

In an application that's not a database engine managing byte slices over several partitions gets old very fast.

I implemented a crude wrapper over partitions that are essentially just:

  • Partition<K, V> newtypes that call the underlying partitions
  • Keys and values implement a conversion trait from/to Slice (e.g. here)

If you are interested in such API, I could finish and tidy up my implementation and submit a PR.

@marvin-j97 marvin-j97 added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers epic api labels Jan 13, 2025
@marvin-j97
Copy link
Collaborator

Maybe as a separate crate akin to https://crates.io/crates/typed-sled ?

I don't want to increase the API surface of this crate further, to me it's more or less stabilized now (until v3...).

@tamasfe
Copy link
Author

tamasfe commented Jan 13, 2025

Yeah, makes sense, since it's just built on top, it shouldn't depend on anything that's not public API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api enhancement New feature or request epic good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants