Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling labels for logging, metrics and debug commands #189

Open
diafour opened this issue Jul 6, 2020 · 0 comments
Open

Refactor handling labels for logging, metrics and debug commands #189

diafour opened this issue Jul 6, 2020 · 0 comments
Milestone

Comments

@diafour
Copy link
Contributor

diafour commented Jul 6, 2020

There is a myriad of map[string]string initialized and passed between layers. The upper-level code should know which labels to pass to the lower-level methods and lower-level has no access to additional information.
It seems that Context can help: labels can be stored as context values. Upper-level code just pass a context and lower-level code retrieve everything from this context.

flant/addon-operator#138

@diafour diafour added this to the future milestone Mar 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant