Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix debug process #8

Closed
diafour opened this issue Apr 17, 2019 · 3 comments
Closed

Fix debug process #8

diafour opened this issue Apr 17, 2019 · 3 comments
Labels
enhancement New feature or request
Milestone

Comments

@diafour
Copy link
Contributor

diafour commented Apr 17, 2019

Part 1

  • Remove --debug=yes flag
  • Remove disableDebug parameter in onKubernetesEvent binding
  • Migrate to logrus library
    • json logs
    • timestamps
    • custom log format

Part 2

  • Remove files in /tmp after hook run
  • debug over http: binding_context file, hook output for each hook run
  • add settings for two endpoints: debug and metrics. DEBUG_LISTEN_ADDRESS, LISTEN_ADDRESS.
    • LISTEN_ADDRESS=:9115 — current setting — listen on 0.0.0.0 on 9115 port
    • LISTEN_ADDRESS=127.0.0.1:9115 — listen on localhost

Update 22.01.2020:

@diafour diafour added this to the 1.0.0 milestone Oct 9, 2019
@diafour diafour modified the milestones: 1.0.0, 1.0.0-beta.7 Jan 22, 2020
@diafour
Copy link
Contributor Author

diafour commented Jan 22, 2020

A specification for debug endpoint:

  • use unix socket /var/run/shell-operator/debug.socket
  • endpoints:
    • /debug/queue.json
    • /debug/queue.yaml
    • /debug/queue — text representation
  • add cli command debug into shell-operator binary:
    • shell-operator debug queue [-o yaml|json]
  • do not forget that addon-operator will include more endpoints and sub-commands for values!

@diafour diafour modified the milestones: 1.0.0-beta.7, 1.0.0-beta.8 Jan 24, 2020
@diafour diafour added the enhancement New feature or request label Jan 24, 2020
@diafour
Copy link
Contributor Author

diafour commented Jan 24, 2020

Refined cli spec:

addon-operator queue list  [-o yaml|json] — list all available queues with their sizes
addon-operator queue dump  [-o yaml|json] — dump queues and their tasks
addon-operator queue task list <q-name> — dump tasks in one queue
addon-operator queue task drop <q-name> <task-id> — drop queued task
addon-operator queue task drop-all <q-name> — drop all tasks from queue
addon-operator log level — return current log level
addon-operator log level --set debug — set log level in runtime

@diafour
Copy link
Contributor Author

diafour commented Feb 6, 2020

Done in #105. Next step is #101

@diafour diafour closed this as completed Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant