Day.js plugins and Typescript

[lhsazevedo]

Originally posted at #2391

Even not using directly, we need to import relativeTime dayjs plugin at js/src/common/utils/humanTime.ts. Without this import, typescript can't pick up tipes for the fromNow() method and complains.
The code still works though, because relativeTime plugin is installed at js/src/common/index.js:

https://github.com/flarum/core/blob/2ff46f5a2ebe2532f780f6e60a921beb41876d69/js/src/common/index.js#L12-L16

We can avoid this import if we move this plugin installation process to a separated dayjs library module, something like:

// js/src/common/lib/dayjs.ts

import dayjs from 'dayjs'
import relativeTime from 'dayjs/plugin/relativeTime';

dayjs.extend(relativeTime)

export default dayjs


// js/src/common/utils/humanTime.ts

// no need import relativeTime from 'dayjs/plugin/relativeTime';
import dayjs from '../../common/lib/dayjs'

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[stale]

We are closing this issue as it seems to have grown stale. If you still encounter this problem with the latest version, feel free to re-open it.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. We do this to keep the amount of open issues to a manageable minimum.
In any case, thanks for taking an interest in this software and contributing by opening the issue in the first place!

[davwheat]

A better option is to include this plugin in the TS global typings file we have jQuery and such in at the moment.

[lhsazevedo]

I would like to try this! Would you mind if I do?

[davwheat]

Go for it!