You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Pull #3359 added useful aria Feed markup to discussion lists. The calculation that works out which number each item in the feed starts at has a small bug. The article count begins at zero instead of 1:
aria-posinset={pageNum * pageSize + itemNum}
Steps to Reproduce
You can see this in action by inspecting the HTML generated for the main discussion list at discuss.flarum.org:
Authors MUST set the value for aria-posinset to an integer greater than or equal to 1, and less than or equal to the size of the set when that size is known. Authors SHOULD use aria-setsize.
Screenshots
No response
Environment
Flarum version: 1.8.9
Output of php flarum info
No response
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered:
Current Behavior
Pull #3359 added useful aria Feed markup to discussion lists. The calculation that works out which number each item in the feed starts at has a small bug. The article count begins at zero instead of 1:
aria-posinset={pageNum * pageSize + itemNum}
Steps to Reproduce
You can see this in action by inspecting the HTML generated for the main discussion list at discuss.flarum.org:
Expected Behavior
Per the WAI-ARIA specification for this attribute,
aria-posinset
needs to start at 1:Screenshots
No response
Environment
Output of
php flarum info
No response
Possible Solution
No response
Additional Context
No response
The text was updated successfully, but these errors were encountered: