Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign-up process should not reveal info #171

Open
gsmachado opened this issue May 12, 2023 · 6 comments
Open

Sign-up process should not reveal info #171

gsmachado opened this issue May 12, 2023 · 6 comments

Comments

@gsmachado
Copy link
Contributor

If the login doesn't work or doesn't exist

@sdkalchofner
Copy link
Contributor

@gsmachado Currently, we only display that there is no match for this combination. We don't reveal if a) the account does not exist or b) that the password is incorrect. Therefore, at least in my opinion, no "valuable" information is revealed in the current message displayed.

What message would you prefer in case we still should change it? "Oops something went wrong." Seems too generic IMHO, I'd think there was a problem with the server and probably would try the same combination again.

@gsmachado
Copy link
Contributor Author

Sign-up:
Account already exists. Would you like to recover the password?

@sdkalchofner
Copy link
Contributor

@gsmachado just saw this now, will implement accordingly.

That info you provided is only for the sign up, what about the login?
Or is the current text for the login ok?

@gsmachado
Copy link
Contributor Author

@sdkalchofner I think on the login page we already have the text. I think it's fine for the login.

For the sign-up, I think it'd be good to display something like "Account already exists. Would you like to recover the password?" and then make the "recover password" clickable to the same page as the "forgot your password?" on the current login page.

That's my 2 cents.

@gsmachado
Copy link
Contributor Author

This is not ESSENTIAL until the live, but if it's relatively easy to do, why not? 😄

@sdkalchofner
Copy link
Contributor

@gsmachado Well, displaying a different error is a simple label change so easy :p

Differentiating between account exists error and general error also simple, but needs more time haha

But in that case I'll wait until after go live with this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants