Check for icon sizes

[hadess]

I've just built BambuStudio and didn't have smaller size icons installed, just 256x256 and 512x512.

This resulted in a broken icon in gnome-shell.

The linter should probably check, after the build, that the software installs a wider array of icon sizes.

[bbhtt]

Your 128px icon is named wrong, it wasn't exported at all.

The icon name in the exported desktop file is wrong. It can't load an icon flatpak didn't export.

The linter should start parsing desktop files to check if everything is correct

[bbhtt]

The linter should probably check, after the build, that the software installs a wider array of icon sizes.

This depends on application to application. Some might require a 16px png icon specifically for tray, if it is a svg there is nothing to check, for most max of 512px is enough because appstream creates 64px and 128px pngs from it

Right now the linter only checks if a 128px icon is present.

[hadess]

There were certainly a whole bunch of errors in that code. My excuse is that the build takes ages... Seems that we agree that there's room for improvement on the linter side though, right?

[bbhtt]

Yea, it should definitely check desktop files, which would've caught this. I thought appstream would've failed here, given how picky it is.

[hfiguiere]

if it export a 256x256 or 512x512, appstream compose will generate what is need things will work.

we do check icon size on buildbot. Even before the linter.

[bbhtt]

#245 will catch the main issue here.

The icon name in the exported desktop file is wrong.