Redesign the layout and inner workings of the package

[orowith2os]

To put it simply and kindly: this is absolutely horrible and confusing and convoluted, no offense.

You should be using the pip flatpak-builder tool to generate the sources, and the MPV module is an.... experience, to say the least.

You should have the screenshots in a dedicated screenshots/ directory, not at the root of the repo.

You can rename the script to just jellyfin, the whole reverse-dns naming thing isn't needed there. The same for the desktop and metadata file, actually, you just need to put those two with the correct name (or rename, that's integrated into the build system, I think?) when you go to package this.

Change the icon to an SVG, ideally.

You can put any non-build-related stuff (like the metadata) into a data/ directory.

[lwbt]

[...] the MPV module is an.... experience, to say the least.

MPV? The only thing I can find about MPV is this issue here. Was it a typo and you meant something else?

You should have the screenshots in a dedicated screenshots/ directory, not at the root of the repo.

I moved them to the branding/ directory, is this okay?

You can rename the script to just jellyfin, the whole reverse-dns naming thing isn't needed there.

Done. Renamed to jellyfin.sh.

The same for the desktop and metadata file, actually, you just need to put those two with the correct name (or rename, that's integrated into the build system, I think?) when you go to package this.

Not sure about this one. 😕 Using $FLATPAK_ID in some places makes the code appear more readable and easier to maintain to me. If there is a variable that contains a more readable value I'd gladly use that.

Change the icon to an SVG, ideally.

Done.

You can put any non-build-related stuff (like the metadata) into a data/ directory.

Okay. I moved some parts there, but I'd like to keep metainfo at the to level until I understood how it works. A few other repositories ship it as part of the main source code and generate release notes programmatically.