Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Tappable Polylines #1685

Closed
thomascoumau opened this issue Oct 10, 2023 · 3 comments
Closed

[FEATURE] Tappable Polylines #1685

thomascoumau opened this issue Oct 10, 2023 · 3 comments
Labels
feature This issue requests a new feature P: 3 (low) (Default priority for feature requests)

Comments

@thomascoumau
Copy link

What do you want implemented?

I wanted to implement an onTap for PolylineLayer. This tap could be specific for each polyline in the layer.

What other alternatives are available?

There is a package TappablePolyline, however, the tap is not really functional and the layer take the size of the all map so the mapTap is inconsistently triggered

Can you provide any other information?

I will propose a PR soon

Severity

Annoying: Currently have to use workarounds
@thomascoumau thomascoumau added feature This issue requests a new feature P: 3 (low) (Default priority for feature requests) labels Oct 10, 2023
@thomascoumau thomascoumau mentioned this issue Oct 10, 2023
Closed
@thomascoumau
Copy link
Author

I have made a draft PR for now here

@JaffaKetchup JaffaKetchup linked a pull request Oct 16, 2023 that will close this issue
Feature: Add a polyline Tap #1686
Closed
@JaffaKetchup JaffaKetchup mentioned this issue Oct 16, 2023
Closed
@thomascoumau
Copy link
Author

I have opened #1697 in order to prepare future PR's in both FM and FMTP repo in the future.

@JaffaKetchup JaffaKetchup changed the title Polyline onTap [FEATURE] Tappable Polylines Oct 20, 2023
@JaffaKetchup
Copy link
Member

I'm going to close this for now, as this won't be included in the core.

@JaffaKetchup JaffaKetchup closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature This issue requests a new feature P: 3 (low) (Default priority for feature requests)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature: Add a polyline Tap thomascoumau/flutter_map
2 participants
@JaffaKetchup @thomascoumau