Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] CenterZoom is no longer exposed in API #1977

Closed
ko16a46 opened this issue Oct 14, 2024 · 3 comments
Closed

[BUG] CenterZoom is no longer exposed in API #1977

ko16a46 opened this issue Oct 14, 2024 · 3 comments
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality S: core Scoped to the core flutter_map functionality

Comments

@ko16a46
Copy link

ko16a46 commented Oct 14, 2024

What is the bug?

Previously, the CenterZoom class was exposed publicly, and our code was using it quite a bit.

However, it was seemingly removed from the exports file during recent refactors. When I updated our app's flutter_map package to the next major version, our code broke.

As a workaround, I just added the CenterZoom class back in to our own code. It seems there are no public APIs in this package that require CenterZoom anyway tho I could be mistaken. Our app was mainly using it as a convenience class.

If this removal was a mistake, then perhaps it should be added back. It was technically a breaking change that wasn't reported in the changelog.

How can we reproduce it?

  1. Create a new flutter app with flutter create my_app
  2. Run flutter pub add flutter_map
  3. Try to use the CenterZoom class in the flutter app

Expected: can use the CenterZoom class
Actual: IDE reports that CenterZoom isn't defined

Do you have a potential solution?

export lib/src/misc/center_zoom.dart from flutter_map.dart

Platforms

all

Severity

Minimum: Allows normal functioning

@ko16a46 ko16a46 added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Oct 14, 2024
@josxha
Copy link
Contributor

josxha commented Oct 14, 2024

Thanks for the bug report.
CenterZoom is not used any in the package any more and should get removed.
Your solution to copy it into your project if you want to keep it is a good solution.

@JaffaKetchup
Copy link
Member

Whoops, missed that in the migration summary, sorry!

@JaffaKetchup JaffaKetchup closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
@JaffaKetchup JaffaKetchup added invalid This bug could not be reproduced or does not exist, or is very low quality S: core Scoped to the core flutter_map functionality and removed needs triage This new bug report needs reproducing and prioritizing labels Oct 14, 2024
@ko16a46
Copy link
Author

ko16a46 commented Oct 14, 2024

Thanks for the bug report. CenterZoom is not used any in the package any more and should get removed. Your solution to copy it into your project if you want to keep it is a good solution.

Ah noted, thanks for the info!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue reports broken functionality or another error invalid This bug could not be reproduced or does not exist, or is very low quality S: core Scoped to the core flutter_map functionality
Projects
None yet
Development

No branches or pull requests

3 participants