You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
ko16a46 opened this issue
Oct 14, 2024
· 3 comments
Labels
bugThis issue reports broken functionality or another errorinvalidThis bug could not be reproduced or does not exist, or is very low qualityS: coreScoped to the core flutter_map functionality
Previously, the CenterZoom class was exposed publicly, and our code was using it quite a bit.
However, it was seemingly removed from the exports file during recent refactors. When I updated our app's flutter_map package to the next major version, our code broke.
As a workaround, I just added the CenterZoom class back in to our own code. It seems there are no public APIs in this package that require CenterZoom anyway tho I could be mistaken. Our app was mainly using it as a convenience class.
If this removal was a mistake, then perhaps it should be added back. It was technically a breaking change that wasn't reported in the changelog.
How can we reproduce it?
Create a new flutter app with flutter create my_app
Run flutter pub add flutter_map
Try to use the CenterZoom class in the flutter app
Expected: can use the CenterZoom class
Actual: IDE reports that CenterZoom isn't defined
Do you have a potential solution?
export lib/src/misc/center_zoom.dart from flutter_map.dart
Platforms
all
Severity
Minimum: Allows normal functioning
The text was updated successfully, but these errors were encountered:
ko16a46
added
bug
This issue reports broken functionality or another error
needs triage
This new bug report needs reproducing and prioritizing
labels
Oct 14, 2024
Thanks for the bug report. CenterZoom is not used any in the package any more and should get removed.
Your solution to copy it into your project if you want to keep it is a good solution.
JaffaKetchup
added
invalid
This bug could not be reproduced or does not exist, or is very low quality
S: core
Scoped to the core flutter_map functionality
and removed
needs triage
This new bug report needs reproducing and prioritizing
labels
Oct 14, 2024
Thanks for the bug report. CenterZoom is not used any in the package any more and should get removed. Your solution to copy it into your project if you want to keep it is a good solution.
bugThis issue reports broken functionality or another errorinvalidThis bug could not be reproduced or does not exist, or is very low qualityS: coreScoped to the core flutter_map functionality
What is the bug?
Previously, the
CenterZoom
class was exposed publicly, and our code was using it quite a bit.However, it was seemingly removed from the exports file during recent refactors. When I updated our app's
flutter_map
package to the next major version, our code broke.As a workaround, I just added the
CenterZoom
class back in to our own code. It seems there are no public APIs in this package that requireCenterZoom
anyway tho I could be mistaken. Our app was mainly using it as a convenience class.If this removal was a mistake, then perhaps it should be added back. It was technically a breaking change that wasn't reported in the changelog.
How can we reproduce it?
flutter create my_app
flutter pub add flutter_map
CenterZoom
class in the flutter appExpected: can use the
CenterZoom
classActual: IDE reports that
CenterZoom
isn't definedDo you have a potential solution?
export
lib/src/misc/center_zoom.dart
fromflutter_map.dart
Platforms
all
Severity
Minimum: Allows normal functioning
The text was updated successfully, but these errors were encountered: