Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fixed Android example app build for CI/CD #1985

Merged
merged 1 commit into from
Nov 17, 2024
Merged

chore: fixed Android example app build for CI/CD #1985

merged 1 commit into from
Nov 17, 2024

Conversation

JaffaKetchup
Copy link
Member

No description provided.

@JaffaKetchup JaffaKetchup mentioned this pull request Nov 17, 2024
Merged
josxha
josxha approved these changes Nov 17, 2024
View reviewed changes
Copy link
Contributor

@josxha josxha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Did you regenerate the android integration?

@JaffaKetchup
Copy link
Member Author

Yep, copied it out of one of my other projects that I recently regenerated and fixed this same issue on (and ran AGP on), then just changed the necessary strings.

@JaffaKetchup JaffaKetchup merged commit 59d7f69 into master Nov 17, 2024
8 checks passed
@JaffaKetchup JaffaKetchup deleted the fix-android-build branch November 17, 2024 20:44
@monsieurtanuki monsieurtanuki mentioned this pull request Dec 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josxha josxha josxha approved these changes

@ibrierley ibrierley Awaiting requested review from ibrierley

@mootw mootw Awaiting requested review from mootw

@TesteurManiak TesteurManiak Awaiting requested review from TesteurManiak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaffaKetchup @josxha