Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitOps: install_software.package_path isn't relative to lib/policies-name.policies.yml file #25867

Closed
marko-lisica opened this issue Jan 29, 2025 · 2 comments
Closed

GitOps: install_software.package_path isn't relative to lib/policies-name.policies.yml file #25867

marko-lisica opened this issue Jan 29, 2025 · 2 comments
Assignees
@marko-lisica
Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) ~released bug This bug was found in a stable release.

Comments

@marko-lisica
Copy link
Member

marko-lisica commented Jan 29, 2025 •
edited
Loading

Fleet version: 4.62.0

💥  Actual behavior

We documented path that's not relative here.

Image

The path should be (because policies files should be in lib):

install_software:
  package_path: "./lib/linux-firefox.deb.package.yml"

🧑‍💻  Steps to reproduce

  1. Create {name}.policies.yml file with few policies
  2. Add install_software.package_path to one policy and make sure that package_path is relative

🕯️ More info (optional)

N/A

🛠️ To fix

Product designer: @marko-lisica

Make sure that paths used in policies (lib/policies-name.policies.yml) file is relative to that file.
@marko-lisica marko-lisica added :incoming New issue in triage process. :reproduce Involves documenting reproduction steps in the issue bug Something isn't working as documented #g-mdm MDM product group labels Jan 29, 2025
@georgekarrv georgekarrv removed the :reproduce Involves documenting reproduction steps in the issue label Jan 30, 2025
marko-lisica added a commit that referenced this issue Jan 30, 2025
@marko-lisica
Update path example for install_software.package_path
4dc6e3c 
Related to #25867 

Paths are relative. Fixed in 4.58.0.
@marko-lisica marko-lisica mentioned this issue Jan 30, 2025
Merged
@marko-lisica marko-lisica added the :product Product Design department (shows up on 🦢 Drafting board) label Jan 30, 2025
rachaelshaw pushed a commit that referenced this issue Jan 31, 2025
@marko-lisica @noahtalerman
Update path example for install_software.package_path (#25895)
d30b8fd 
Related to #25867 

Paths are relative. Fixed in
[4.58.0](https://github.com/fleetdm/fleet/blob/main/CHANGELOG.md?plain=1#L308).

---------

Co-authored-by: Noah Talerman <[email protected]>
@lukeheath lukeheath added the ~released bug This bug was found in a stable release. label Jan 31, 2025
@marko-lisica
Copy link
Member Author

This was documentation bug. PR is merged: #25895.

@fleet-release
Copy link
Contributor

Paths in code like river's flow,
Fleet's harmony now does grow.
Docs reflect truth's glow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marko-lisica marko-lisica

Labels
bug Something isn't working as documented #g-mdm MDM product group :incoming New issue in triage process. :product Product Design department (shows up on 🦢 Drafting board) ~released bug This bug was found in a stable release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@georgekarrv @lukeheath @fleet-release @marko-lisica