Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add github actions workflows for CI and publish #20

Open
shubhamzanwar opened this issue Apr 12, 2020 · 7 comments
Open

Add github actions workflows for CI and publish #20

shubhamzanwar opened this issue Apr 12, 2020 · 7 comments
Assignees
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed

Comments

@shubhamzanwar
Copy link
Collaborator

No description provided.

@shubhamzanwar shubhamzanwar added good first issue Good for newcomers help wanted Extra attention is needed labels Apr 12, 2020
@hussamkhatib
Copy link
Contributor

hey maintainer ! can you assign this issue to me
just to confirm does "Add github actions workflows for CI and publish" means auto deploy website on a push in the repo in the branch gh pages?

@shubhamzanwar
Copy link
Collaborator Author

Yes, we could start with that. When a new commit is pushed, we can redeploy the website
Eventually, we should also add a workflow to publish the package to npm registry when a new tag is pushed

@hussamkhatib
Copy link
Contributor

cool i will start with website thing first.

@hussamkhatib
Copy link
Contributor

I think this won't be required for website as it is deployed with github pages.
Changes will made on push automatically.

@shubhamzanwar
Copy link
Collaborator Author

You would still need to deploy the website by running yarn deploy inside the website folder.
Instead of doing it manually, we could write a github action to do the same on every commit push to master.

What do you think?

@hussamkhatib
Copy link
Contributor

sure.
i dint realize there was a website folder in master branch.
I thought everything was served in gh-pages branch.

@hussamkhatib
Copy link
Contributor

i could find this workflow from github action.
I am still not sure if i am doing it right ,this is what i have tried ⬇️.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers Hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants