Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[shared_preferences_tizen] Question: Is the tizen version compatible with 2.3.0+ of the base package? Please upgrade if not #745

Closed
T-h-e-Wizard opened this issue Sep 14, 2024 · 3 comments

Comments

@T-h-e-Wizard
Copy link

The subject pretty much says it all. The base shared_preferences package is currently at version 2.3.2, and its authors have announced that legacy API will be deprecated, and newer code should be written using SharedPreferencesAsync or SharedPreferencesWithCache APIs. If the tizen version is not compatible w/ these, it forces users to stick to a "soon to be deprecated" API, which is not preferrable.

I haven't tested the versions yet, and the current tizen version might just work out of the box with 2.3+ base version, but if the developers here can confirm that it's not just "lucky" but indeed working as designed, that would be nice (a change in the readme.md would also help then). If, however, the tizen version is not compatible with 2.3+ of the base, then it's a deterrent to newcomers I think, and should be addressed earlier, rather than later. Thanks!

@swift-kim
Copy link
Member

@JSUYA Could you please check? I haven't looked into the details but we may need to rewrite the Tizen implementation to support both APIs (the Async and Cache versions).

@JSUYA
Copy link
Member

JSUYA commented Sep 20, 2024

I think.. I should implement the interface of SharedPreferencesAsyncPlatform. I'm preparing a patch. I'll make a PR once it's done.

@swift-kim
Copy link
Member

Should have been fixed by #748. Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants