Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quotes in the 245 field cause Anaylze MARC to report an error #41

Open
lmccoll44 opened this issue Feb 14, 2022 · 13 comments
Open

Quotes in the 245 field cause Anaylze MARC to report an error #41

lmccoll44 opened this issue Feb 14, 2022 · 13 comments

Comments

@lmccoll44
Copy link

If a MARC file is loaded with a title that has quotes, the Analyze MARC feature gives the following error:

image

It is acceptable to have quotes in the 245 field.

Thank you.

@nielserik
Copy link
Collaborator

nielserik commented Feb 14, 2022

Yes, that's acceptable, or rather, it should be.

What happens is, that the record has no ISBN, which would have been used to potentially link the order to a existing Instance. So the tool checks if there is another instance with the same title in FOLIO already, to display an alert about the missing linking if there is.

This lookup is what goes wrong. For what it's worth, it's the combination of a quoted section AND a forward slash that throws FOLIO's CQL parser off. Leave either of them out and the lookup will parse alright, and also find the given title (if it exists).

Since the query works with the quotes left out, I suppose we could have the tool strip quotes from the title query before URL encoding the query and sending off the request to FOLIO.

@nielserik
Copy link
Collaborator

title-with-quotes-no-isbn

This is what it looks like, if the record has no ISBN and the tool then strips quotes from the title before sending of a query to check for an existing instance by that title.

@nielserik
Copy link
Collaborator

I have a pull request with that solution if we think it's good. #42

@lmccoll44
Copy link
Author

I think it will work for us. I would want that to work for Chicago as well of course. To be honest I'm still struggling with dealing with that matching. My understanding is that it will be able to be turned off with Lotus. We're stripping out potential match points right now so we do not get an accidental match. I thought I would mention that in case it affects others' view of this process. Thank you for the explanation too, Niels. That is really interesting.

@maccabeelevine
Copy link
Collaborator

Seems good to me as well!

@nielserik
Copy link
Collaborator

Thanks guys.

@lmccoll44 Are you stripping off match points from the incoming MARC records? UChicago has reduced the identifiers that they use for matching to just ISBN in their mapping - the "chi" mapping:

public List<String> applicableProductIdentifierTypeIds() {
. They don't need to take identifiers out of the MARC for that.

The other two mapping variations, "sigma" and "lambda", however, use the default set, which is

public List<String> applicableProductIdentifierTypeIds() {

If everybody actually wants to go by only ISBN for matching, we can implement that across the board. This doesn't limit what identifiers are populated on the Instance, it only limits which of them that are used as product identifiers in Orders' matching logic.

@lmccoll44
Copy link
Author

@nielserik - Unfortunately the ISBN for us I think is the most likely to cause a false match since ISBNs for multiple formats of a work are frequently included in one record. We already had this happen - a print book order found an ebook in FOLIO and attached itself to that record. I'll have to think through the process better. Ideally we would have a warning of a match and the opportunity to say "yes" or "no" before the match was made.

@nielserik
Copy link
Collaborator

@lmccoll44 Ah, I see. I don't suppose omitting the ISBN and go with some of the other identifiers would work for you either?

I hear you regarding an interactive mode, I suppose that would be for another generation of the tool (and the tool is officially still a temporary remedy so I don't know how many "generations" there will be)

@nielserik
Copy link
Collaborator

I'm wondering how crucial an interactive mode would be for you. If it's a major thing, might it be something that @maccabeelevine would consider looking into developing by any chance?

@maccabeelevine
Copy link
Collaborator

I think I missed the initial suggestion of an interactive mode, will chat with @lmccoll44 but yes if needed I could find the time to build that. I tend to agree with @nielserik 's point about this being a temporary tool, but who knows what temporary means.

@lmccoll44
Copy link
Author

lmccoll44 commented Feb 15, 2022 via email

@nielserik
Copy link
Collaborator

Right, I mention temporary because making the import stop and have the user decide how to proceed in given circumstances (when multiple ISBNs?) seems like it could be a not entirely trivial extension to develop.

@lmccoll44
Copy link
Author

Makes sense!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants