From bc4726f989379cc3ca6f8cdd35264b998ea43437 Mon Sep 17 00:00:00 2001
From: Fons van der Plas <fonsvdplas@gmail.com>
Date: Sun, 22 Oct 2023 17:11:46 +0200
Subject: [PATCH] frontend test stability

---
 frontend/components/welcome/Featured.js | 5 -----
 frontend/components/welcome/Recent.js   | 4 ++--
 frontend/index.html                     | 2 +-
 frontend/welcome.css                    | 8 ++++----
 test/frontend/helpers/pluto.js          | 2 ++
 5 files changed, 9 insertions(+), 12 deletions(-)

diff --git a/frontend/components/welcome/Featured.js b/frontend/components/welcome/Featured.js
index 6937d13241..08f9a4e84b 100644
--- a/frontend/components/welcome/Featured.js
+++ b/frontend/components/welcome/Featured.js
@@ -119,13 +119,8 @@ export const Featured = ({ sources, direct_html_links }) => {
             set_waited_too_long(false)
             set_source_data({})
 
-            // Start downloading the sources
-
             const ids = Array.from(new Set(sources.map(get_id)))
 
-            console.log(ids)
-            console.log("123123123213123")
-
             const promises = ids.map((id) => {
                 const sources_for_id = sources.filter((source) => get_id(source) === id)
 
diff --git a/frontend/components/welcome/Recent.js b/frontend/components/welcome/Recent.js
index 2fbc72d5d4..c9b7e13845 100644
--- a/frontend/components/welcome/Recent.js
+++ b/frontend/components/welcome/Recent.js
@@ -181,7 +181,7 @@ export const Recent = ({ client, connected, remote_notebooks, CustomRecent, on_s
 
     let recents =
         combined_notebooks == null
-            ? html`<li><em>Loading...</em></li>`
+            ? html`<li class="not_yet_ready"><em>Loading...</em></li>`
             : combined_notebooks.map((nb) => {
                   const running = nb.entry != null
                   return html`<li
@@ -221,7 +221,7 @@ export const Recent = ({ client, connected, remote_notebooks, CustomRecent, on_s
     if (CustomRecent == null) {
         return html`
             <h2>My work</h2>
-            <ul id="recent" class="show-scrollbar">
+            <ul id="recent" class="show_scrollbar">
                 <li class="new">
                     <a
                         href="new"
diff --git a/frontend/index.html b/frontend/index.html
index 5aff4717ac..0c235dc91b 100644
--- a/frontend/index.html
+++ b/frontend/index.html
@@ -46,7 +46,7 @@ <h1>welcome to <img src="img/logo.svg"></h1>
         <section id="mywork">
             <div>
                 <h2>My work</h2>
-                <ul id="recent">
+                <ul id="recent" class="not_yet_ready">
                     <li class="new"><a href="new"><button><span class="ionicon"></span></button>Create a <strong>new notebook</strong></a></li>
                     <li><em>Loading...</em></li>
                 </ul>
diff --git a/frontend/welcome.css b/frontend/welcome.css
index 891ab44c37..87436e1cea 100644
--- a/frontend/welcome.css
+++ b/frontend/welcome.css
@@ -257,18 +257,18 @@ a#github {
     right: 0.5rem;
 }
 
-.show-scrollbar::-webkit-scrollbar {
+.show_scrollbar::-webkit-scrollbar {
     width: 10px;
     opacity: 0.1;
 }
-.show-scrollbar::-webkit-scrollbar-track {
+.show_scrollbar::-webkit-scrollbar-track {
 }
-.show-scrollbar::-webkit-scrollbar-thumb {
+.show_scrollbar::-webkit-scrollbar-thumb {
     /* height: 11px; */
     background-color: var(--black);
     opacity: 0.6;
     border-radius: 1000px;
 }
-.show-scrollbar::-webkit-scrollbar-thumb:hover {
+.show_scrollbar::-webkit-scrollbar-thumb:hover {
     opacity: 1;
 }
diff --git a/test/frontend/helpers/pluto.js b/test/frontend/helpers/pluto.js
index 1ad04d9520..044dd4c407 100644
--- a/test/frontend/helpers/pluto.js
+++ b/test/frontend/helpers/pluto.js
@@ -102,6 +102,8 @@ export const importNotebook = async (page, notebookName, { permissionToRunCode =
  * @param {string} path_or_url
  */
 export const openPathOrURLNotebook = async (page, path_or_url, { permissionToRunCode = true } = {}) => {
+    await page.waitForFunction(() => document.querySelector(`.not_yet_ready`) == null)
+
     const openFileInputSelector = "pluto-filepicker"
     await writeSingleLineInPlutoInput(page, openFileInputSelector, path_or_url)
     // await writeSingleLineInPlutoInput(page, openFileInputSelector, notebookPath)