Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve original LOAD_PATH #2748

Merged
merged 2 commits into from
Dec 13, 2023
Merged

preserve original LOAD_PATH #2748

merged 2 commits into from
Dec 13, 2023

Conversation

Pangoraw
Copy link
Collaborator

Closes #2743.

Copy link
Contributor

Try this Pull Request!

Open Julia and type:

julia> import Pkg
julia> Pkg.activate(temp=true)
julia> Pkg.add(url="https://github.com/fonsp/Pluto.jl", rev="copy_load_path")
julia> using Pluto

@fonsp
Copy link
Owner

fonsp commented Dec 12, 2023

@Pangoraw what do you think about the failing tests?

@Pangoraw
Copy link
Collaborator Author

I changed the test because the LOAD_PATH is different when in testing and I did not understand how the LOAD_PATH is propagated to the worker depending on the version.

@fonsp
Copy link
Owner

fonsp commented Dec 12, 2023

Ahh this is because of a change in Distributed in Julia 1.9:

https://docs.julialang.org/en/v1/NEWS/#Distributed

In Malt we never propagate the value, and Malt is enabled by default on Windows only right now.

@Pangoraw
Copy link
Collaborator Author

oooh that makes sense, i changed the test but it may be relying on somehow passing the environment. The fix is working though.

@fonsp fonsp merged commit c999c73 into main Dec 13, 2023
14 checks passed
@fonsp fonsp deleted the copy_load_path branch December 13, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabling the package manager doesn't work anymore
2 participants